Propagate errors from generate_hash_secret_salt up to XML_Parse/XML_ParseBuffer?
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by reading the call tree in the issue: XML_Parse/XML_ParseBuffer, startParsing, and generate_hash_secret_salt. Consider how entropy-source failures could propagate through these entry points and whether a new error code is needed; the issue leaves the design tradeoffs open. Done would mean selecting and implementing an error-propagation approach, with parsing returning an error when entropy generation fails.
Written by the indexing model from the issue text.
Description
At the moment, generate_hash_secret_salt uses fallback code when high quality sources of entropy fail to serve entropy. For the future we could propagate errors upwards so that XML_Parse/XML_ParseBuffer fails with an error, instead. We may need a new error code and consider pros and cons of that approach.
The call tree is:
XML_Parse/XML_ParseBufferstartParsinggenerate_hash_secret_salt
- Dominant language
- C
- Stars
- 1.4k
- Forks
- 555
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 37
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from libexpat/libexpat
-
question
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
libexpat/libexpat#1428 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
question
Difficulty 3/5 1-2 days Newbie friendliness 56/100
libexpat/libexpat#1430 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
question
Difficulty 3/5 1-2 days Newbie friendliness 55/100
libexpat/libexpat#1429 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
question
Difficulty 1/5 Under an hour Newbie friendliness 44/100
libexpat/libexpat#1422 · 1 comment ·
Maintainers usually reply within 1 day
-
Processor state confusion related to CDATA handlingPossibly taken @shivampwm2020 claimed this 8 days ago. Openbug help wanted
Difficulty 4/5 3-5 days Newbie friendliness 12/100
Maintainers usually reply within 1 day
All issues in libexpat/libexpat
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 1/5 Under an hour Newbie friendliness 93/100
webarkit/WebARKitLib#107 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
polhenarejos/pico-fido#302 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
espressif/esp-vision#16 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
libsdl-org/SDL#16577 ·
Maintainers usually reply within 1 day