Don't set logging level when used as a library
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start at Server.serve and Server._setup_logging, then compare how logging is configured in cli.py. Keep library use from changing application and dependency loggers, while preserving the CLI's intended logging behavior; verify the affected server and CLI paths manually or with the repository's existing tests.
Written by the indexing model from the issue text.
Description
Server.serve calls Server._setup_logging which explicitly sets the logging level to INFO and hooks up the tornado logger to the output too.
As a user of a library, I should be able to be in control about what gets printed to the screen of my app and what dependencies of mine log to where.
I can fix this by monkey-patching the code with:
server = Server()
server._setup_logging = lambda: None
server.serve(root=".")
but I think that by default the library should not alter the loggers and they should instead be set in cli.py, allowing the CLI experience to be nice but giving library users the flexibility to set things how they wish.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 149
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lepture/python-livereload
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
lepture/python-livereload#159 · 3 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
lepture/python-livereload#288 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
lepture/python-livereload#283 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
lepture/python-livereload#282 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
lepture/python-livereload#279 ·
All issues in lepture/python-livereload
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Kludex/python-multipart#375 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 3 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 11 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
FuRongJun-1999/dsh-memory#1000 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gcivil-nyu-org/team5-mon-fall26#154 ·
Maintainers usually reply within 1 day