[critical bug] crashes when directory contains unicode
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 30/100
Research direction
The traceback points to livereload/handlers.py, especially filepath at line 162 and get at line 174. Start by reproducing the failure with a directory containing Unicode characters and inspect the path-joining inputs. Done means the server no longer raises UnicodeDecodeError for that directory, with a regression test if the repository provides one.
Written by the indexing model from the issue text.
Description
I got an error like this,
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/tornado/web.py", line 1346, in _execute
result = method(*self.path_args, **self.path_kwargs)
File "/Library/Python/2.7/site-packages/livereload/handlers.py", line 174, in get
filepath = self.filepath(path)
File "/Library/Python/2.7/site-packages/livereload/handlers.py", line 162, in filepath
url = os.path.join(self._root, url)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py", line 73, in join
path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe6 in position 41: ordinal not in range(128)
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 149
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lepture/python-livereload
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
lepture/python-livereload#159 · 3 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
lepture/python-livereload#288 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
lepture/python-livereload#283 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
lepture/python-livereload#282 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
lepture/python-livereload#279 ·
All issues in lepture/python-livereload
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Kludex/python-multipart#375 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 3 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 11 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
FuRongJun-1999/dsh-memory#1000 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gcivil-nyu-org/team5-mon-fall26#154 ·
Maintainers usually reply within 1 day