Delay argument 'forever' has no effect

Open
#125 4 comments 0 reactions 0 assignees View on GitHub

@jerrykan is already working on this.

Since Nov 29, 2020.

  • #236 by @jerrykan — open
  • #253 by @ronnix — open
  • #289 by @johbo — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Read watchers.py at line 81 and trace how the delay value reaches LiveReloadHandler.poll_tasks. Confirm the fix by verifying that a delay of "forever" is returned to poll_tasks instead of being discarded.

Written by the indexing model from the issue text.

Description

in watchers.py:81 delay is set to None if it wasn't an int so a delay value of 'forever' will never be returned to LiveReloadHandler.poll_tasks.

Dominant language
Python
Stars
1.1k
Forks
149
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lepture/python-livereload

All issues in lepture/python-livereload

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.