Receive pushed data into an archive through the Peer protocol
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- backend, databases, distributed-systems
Research direction
Start with DiskSyncConnection in morango/sync/syncsession.py, then read TransferSessionViewSet and BufferViewSet in morango/api/viewsets.py, especially the scope checks at lines 348-354. Review spec §3.6 and implementation-plan Task 23 before implementing the six methods. Done means the listed acceptance criteria pass, including archive writes within assert_no_default_db_queries(); note that work is blocked by issues #367, #371, and #383.
Written by the indexing model from the issue text.
Description
Overview
A disk connection receives a push through the Peer protocol and stores the data in the archive, as a morango server does. This issue is part of milestone M6 (disk connection).
Background & Motivation
The shared Peer* operations from #374 drive a peer only through the Peer protocol. The network connection answers the protocol with HTTP calls to a server. The disk connection must answer the same protocol, with the archive in the role of the server.
The parity rule requires that the archive holds the same state as a server that receives the same push. For this reason, the disk connection calls the same receiver functions that the server uses. It does not use separate write logic.
Design: spec. Plan: implementation plan, Task 23.
User Story
As a Kolibri developer,
I want a push over a disk connection to complete all transfer stages,
So that the exported archive holds the same records and counters as a server.
Description & Expected Outcomes
The disk connection implements the six Peer protocol methods. It rejects a pull, because Phase 1 supports export only.
When a transfer session is created, the disk connection applies the same scope checks as the server. The filter must be in the write scope of the client certificate and the read scope of the archive certificate. The connection records the filter in the manifest.
When an update asks for a later stage, the disk connection runs each stage step in order up to that stage. It stops at the first step that does not complete. The steps compute the archive FSIC, accept record chunks, and dequeue the records into the archive store.
The disk connection returns every result as a PeerTransferSession. All writes to the archive happen inside a transaction on the archive alias.
Deliverables & Contracts
The feature delivers these capabilities:
create_transfer_session,get_transfer_session,update_transfer_session,close_transfer_session,push_record_chunkandpull_record_chunkonDiskSyncConnection, as spec §3.6 describes.- An update to a later stage runs every skipped stage step in order.
- A push through the shared
Peer*operations writesStore,RecordMaxCounterandDatabaseMaxCounterrows in the archive.
Acceptance Criteria
-
create_transfer_sessionfor a pull raisesMorangoError. - A filter outside the certificate scopes raises
MorangoError. -
create_transfer_sessionsets the manifestfilter. -
update_transfer_session(ts, transfer_stage="queuing")frominitializingrunsserializingandqueuing, and returns stagequeuingwith statuscompleted. -
push_record_chunksets the stage totransferringand increasesrecords_transferredby the chunk length. - An update to
dequeuingwritesStore,RecordMaxCounterandDatabaseMaxCounterrows in the archive and increments the archive instance counter. - Two calls to
close_transfer_sessiondo not raise. -
pull_record_chunkraisesMorangoError. - All archive writes pass inside
assert_no_default_db_queries().
Technical Pointers & Architecture
- Target Components / Context:
morango/sync/syncsession.py(DiskSyncConnection). - Related Patterns:
TransferSessionViewSet(morango/api/viewsets.py:319) andBufferViewSet(morango/api/viewsets.py:452) are the server behavior to mirror. The scope checks are atmorango/api/viewsets.py:348-354. - Data Model & Schema Considerations: No schema change.
- Resilience & Failure Modes: The disk connection runs synchronously. Each stage step either completes or raises. Errors must not be suppressed.
Notes & Tradeoffs
- Dependencies: Blocked by: #367 (receiver helpers take
db), #371 (Peer protocol andPeerTransferSession), #383 (disk connection lifecycle). Blocks: #385, #386. - Kolibri companion changes: See spec §3.9. Kolibri routers must allow morango migrations on aliases that start with
morango_archive_. Kolibri settings overrides must list thePeer*operations. - Tradeoffs & Alternatives Considered: The spec rejects a run of the server middleware against the archive. Server operations read the HTTP request, and host operations also run in that path. The contract suite in #385 guards against drift from server behavior.
- Follow-up: A separate issue will split
update_transfer_sessioninto a field update and a stage advance (command-query separation).
Metadata
- Complexity: High
- Target Branch: release-v0.9.x
AI Usage
Drafted with Claude (Claude Code) from the approved design spec and implementation plan. The author reviewed the requirements, and the code references were checked against the release-v0.9.x codebase.
- Dominant language
- Python
- Stars
- 15
- Forks
- 23
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 4
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from learningequality/morango
-
DEV: dev-ops DEV: distributions DOCS: developer
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
learningequality/morango#387 ·
-
DEV: backend DEV: dev-ops TAG: unit tests
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
learningequality/morango#385 ·
-
DEV: backend P0 - critical TAG: tech update / debt TAG: unit tests
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
learningequality/morango#364 ·
-
DEV: backend TAG: new feature
Difficulty 5/5 Over a week Newbie friendliness 10/100
learningequality/morango#388 ·
-
DEV: backend TAG: unit tests
Difficulty 4/5 3-5 days Newbie friendliness 55/100
learningequality/morango#386 ·
All issues in learningequality/morango
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 Half a day Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Qiskit/qiskit-ibm-runtime#3431 · 1 comment ·
Maintainers usually reply within 1 day
-
[Lesson] A compatibility-gate rejection is a verdict, not something to overwrite with --accept-riskOpenlesson-submission needs-ac pending-review
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Ikalus1988/MisakaNet#2870 ·
Maintainers usually reply within 1 day
-
feature:LinkChecker
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
digitalfabrik/integreat-cms#4594 ·
Maintainers usually reply within 5 days