Settings flag chips and channel chips cannot be used from the keyboard
Maintainers usually reply within 1 day
Nobody has claimed this yet.
- #203 by @yff124 — closed without merging
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, react
- Domain
- accessibility, frontend
Research direction
In website/src/SettingsView.jsx, search for saveSetting(k, val(k) and toggle(ch) to find both chip implementations. Read the nearby state and styling, then check website/test/clickableContent.test.mjs for the test pattern. Done when both chips are keyboard reachable buttons with aria-pressed, retain their appearance, toggle with Space or Enter, and a test asserts they are buttons.
Written by the indexing model from the issue text.
Description
On the Settings page, the flag chips (<Box key={k} title={m.flags[k].help} onClick={() => saveSetting(k, …)}>) and the channel chips (<Box key={ch} onClick={() => toggle(ch)}>) are plain clickable boxes. They change real settings, but Tab never reaches them and they do not say whether they are on or off.
Where: website/src/SettingsView.jsx. Search for saveSetting(k, val(k) and toggle(ch).
Done when each chip is a ButtonBase (or <button type="button">) with aria-pressed reflecting its state, looks the same, and Tab plus Space/Enter toggles it.
Test: add a case to website/test/clickableContent.test.mjs (or a new *.test.mjs beside it) asserting the element is now a button.
Getting started: pip install -e ".[dev]", then python -m pytest -q (offline). UI work: cd website && npm ci && npm test (Node 22). See CONTRIBUTING.md. One small PR with the change (and its test, where there is one) is perfect.
- Dominant language
- Python
- Stars
- 116
- Forks
- 22
- Avg merge
- 13h 21m
- Merged PRs (30d)
- 53
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ldbumble/taskuary
-
accessibility good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 92/100
ldbumble/taskuary#161 · 1 comment ·
Maintainers usually reply within 1 day
-
"re-check CI" is a span, and its busy state is colour-onlyMay be free again A pull request for this issue was closed without being merged. Openaccessibility good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ldbumble/taskuary#158 · 1 comment ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
ldbumble/taskuary#147 · 1 comment ·
Maintainers usually reply within 1 day
-
Four Cancel/Dismiss buttons are lowercase while the rest are capitalisedPossibly taken @krishna2707 claimed this 3 days ago. Openenhancement good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 87/100
ldbumble/taskuary#143 · 1 comment ·
Maintainers usually reply within 1 day
-
Avatar style picker on About you is mouse-only and does not announce the selectionMay be free again A pull request for this issue was closed without being merged. Openaccessibility good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
ldbumble/taskuary#140 · 1 comment ·
Maintainers usually reply within 1 day
All issues in ldbumble/taskuary
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
cathrynlavery/diagram-design#441 ·
Maintainers usually reply within 2 days
-
[Cleanup] Include the public header in work_split.cppPossibly taken @blozano-tt claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
tenstorrent/tt-metal#60850 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
backend::sglang bug language::python observability
Difficulty 2/5 Half a day Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
OpenShot/openshot-qt#6202 ·
Maintainers usually reply within 1 day