Should herald support --chain argument, or should the chain (aka env.coin) be inferred from DBState?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- python
- Domain
- blockchain, cli, databases
Research direction
Start with the herald CLI shown in the issue and inspect how --db_dir, --chain, and DBState are handled, then compare that with the scribe --chain setting. Determine whether the chain can be reliably inferred from the database or whether the explicit argument must remain; done means the project has a decided behavior and corresponding documented or tested CLI expectations.
Written by the indexing model from the issue text.
Description
In most cases the DB (--db_dir=X) will have been populated by scribe, and so it's the scribe --chain=Y argument that's determinative.
(venv) swdev1@Jonathans-Mac-mini hub % herald --help
usage: herald [-h] --db_dir DB_DIR [--reorg_limit REORG_LIMIT] [--chain {mainnet,regtest,testnet}] [--max_query_workers MAX_QUERY_WORKERS] [--cache_all_tx_hashes] [--cache_all_claim_txos]
..snip...
optional arguments:
-h, --help show this help message and exit
--db_dir DB_DIR Path of the directory containing lbry-rocksdb.
--reorg_limit REORG_LIMIT
Max reorg depth
--chain {mainnet,regtest,testnet}
Which chain to use, default is mainnet, others are used for testing
...snip...
- Dominant language
- Python
- Stars
- 15
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lbryio/hub
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Bump to protobuf==3.18.3 within lbry-sdk repo causes MacOS unit test failuresPossibly taken @moodyjon claimed this 1380 days ago. Openpriority: high
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Herald needs to accept ipv6 ping and reply with an ipv6 pongPossibly taken @moodyjon claimed this 1406 days ago. Openarea: herald new feature
-
area: herald type: bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
glossyio/traffic-monitor#264 ·
Maintainers usually reply within 1 day
-
Add self-hostOpen
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Atarity/deploy-your-own-saas#102 ·
-
[Bug]: RDFlex silently drops the covariate adjustment when the outcome or treatment column is integer-typedPossibly taken @vrjdev claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
DoubleML/doubleml-for-py#424 ·
Maintainers usually reply within 1 day
-
agentic-dmx docs enhancement
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
521xueweihan/HelloGitHub#4150 ·