Dead code pertaining to "any_languages" query generation
@shyba is already working on this.
Since May 18, 2022.
Assessment
This issue has not been assessed yet.
Description
Saw this while investigating https://github.com/lbryio/lbry-sdk/issues/3328 and any_languages search term implementation.
...contains duplicate elif cases pertaining to any_languages:
elif key == 'any_languages':
query['must'].append({"terms": {'languages': clean_tags(value)}})
elif key == 'any_languages':
query['must'].append({"terms": {'languages': value}})
Can't say which one is the correct behavior.
- Dominant language
- Python
- Stars
- 15
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lbryio/hub
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Bump to protobuf==3.18.3 within lbry-sdk repo causes MacOS unit test failuresMay be free again @moodyjon claimed this 1352 days ago, and no pull request is open. Openpriority: high
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Herald needs to accept ipv6 ping and reply with an ipv6 pongMay be free again @moodyjon claimed this 1378 days ago, and no pull request is open. Openarea: herald new feature
-
area: herald type: bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Similar issues
-
bug server
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sportsdataverse/sportsdataverse-py#641 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
googleapis/google-cloud-python#18532 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day