Photo credit badges disappear into the black of invert spotlights
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Look at the photo credit badge in coffee.html and index.html inside invert spotlights. The badge is currently an inline style; move it to a class in assets/sass/. Create two variants: a bordered black pill and an inverted white pill. Test both at desktop and 375px on the coffee page to decide which suits each section. The change makes the badge deliberate on both light and dark backgrounds.
Written by the indexing model from the issue text.
Description
The photo credit badge is a black pill with white text and a white camera glyph. Inside an invert spotlight the section background is also black, so the pill disappears and the badge reads as a bare white name floating on the background rather than a credit.
Where it happens today:
coffee.html: the French press, AeroPress and Moka pot spotlights, and the book spotlight once #181's change toinvertlands.index.html: the oneinvertspotlight.
It is legible, but it is the absence of a treatment rather than a treatment. The badge should look deliberate on both backgrounds.
Proposal
Build both variants and pick per section by eye, rather than deciding on one up front:
- Bordered black. Keep the black pill, add a thin white (or near-white) border so it holds its shape against a black section. The badge stays one object on every background.
- Inverted. A white pill with black text and a black glyph, used on
invertsections. Reads as the same badge in the section's own colour scheme, and matches the way the rest of the spotlight's text inverts.
Both get built, both get rendered at desktop and at 375px on the coffee page, and the choice is made from the screenshots. They are not exclusive: the bordered black may suit the banner, where the badge sits over a photo rather than a flat colour, while the inverted one suits the flat black sections.
Implementation note
The badge is currently a ~600-character inline style attribute, repeated verbatim for every credit on the site, and most pages carry one. Adding a second variant by hand means a second 600-character blob to keep in step with the first. Worth lifting the badge into a class in assets/sass/ first, with a modifier for the variant, so the markup becomes <span class="credit credit-invert"> and the two variants are defined once. That also makes the remaining decisions in #183 one-line changes instead of a find-and-replace across every page.
Related
Supersedes the "whether the black pill is the right treatment inside invert spotlights" bullet in #183, which covers making the badges consistently clickable. Split out of #181.
- Dominant language
- HTML
- Stars
- 0
- Forks
- 0
- Avg merge
- 8h 17m
- Merged PRs (30d)
- 58
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from laywill/laywill.github.io
-
design
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
laywill/laywill.github.io#183 · 1 comment ·
-
Difficulty 2/5 Half a day Newbie friendliness 74/100
laywill/laywill.github.io#135 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
laywill/laywill.github.io#106 ·
-
infra needs-william
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
laywill/laywill.github.io#35 · 1 comment ·
-
infra
Difficulty 3/5 1-2 days Newbie friendliness 65/100
laywill/laywill.github.io#187 ·
All issues in laywill/laywill.github.io
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
lobehub/lobe-icons#422 · 1 comment ·
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
enhancement feature request
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nasa-jpl/explorer-1#908 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
henit-chobisa/deck#20 ·