Make photo credit badges consistently clickable
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- html
- Domain
- frontend
Research direction
Inspect the photo credit badges in index.html and coffee.html, comparing the own-photo spans with the existing Unsplash links. Update the own-photo badges to point to photographer.html, then verify every badge is clickable and decide whether the invert styling and aria-label need adjustments.
Written by the indexing model from the issue text.
Description
Photo credit badges across the site come in two shapes:
- Unsplash photos use an
<a>linking to the photo or photographer, e.g. the four onindex.htmland the three oncoffee.html. - William's own photos use a
<span>with the same styling and atitle="Photograph by William Lay", so the badge looks identical but does nothing. Currently the photographer spotlight onindex.htmland the book and French press spotlights oncoffee.html.
A reader cannot tell the difference until they try to click, and a badge that looks like a link but is inert reads as an unfinished placeholder rather than a deliberate credit.
Proposal: make the own-photo badges link to photographer.html, so every badge on the site is clickable and the credit clearly points at a person on purpose.
Worth deciding at the same time:
- Whether the black pill is the right treatment inside
invertspotlights. On a black section the pill disappears and only the white camera icon and name remain. It is legible and already the behaviour onindex.html, but it is accidental rather than designed. - Whether the badge needs an
aria-label, since the camera glyph is decorative and the text alone reads as a bare name.
Split out of #181, where the own-photo badges were first added.
- Dominant language
- HTML
- Stars
- 0
- Forks
- 0
- Avg merge
- 8h 17m
- Merged PRs (30d)
- 58
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from laywill/laywill.github.io
-
design
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
laywill/laywill.github.io#186 ·
-
Difficulty 2/5 Half a day Newbie friendliness 74/100
laywill/laywill.github.io#135 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
laywill/laywill.github.io#106 ·
-
infra needs-william
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
laywill/laywill.github.io#35 · 1 comment ·
-
infra
Difficulty 3/5 1-2 days Newbie friendliness 65/100
laywill/laywill.github.io#187 ·
All issues in laywill/laywill.github.io
Similar issues
-
Browser (wasm) relay client cannot connect to relays whose URL has a trailing-dot FQDN hostname Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
n0-computer/iroh#4550 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nightscout/nocturne#1425 ·
-
ui/ux
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
docToolchain/docToolchain#1705 ·