Domain center does not change when using params['domainCenter']
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start by grepping the repo for domainCenter to find where DFN.params entries are declared, defaulted, and consumed — the bug is that the assignment in the issue is silently overwritten or never propagated. Reproduce with the exact snippet given and trace where the reset happens (initialization or a recompute of the center from domainSize). Done means print(DFN.params['domainCenter']['value']) outputs [0, 0, -30] after the assignment and the layers are placed as written; add a small regression check alongside the existing param-handling tests if any exist.
Written by the indexing model from the issue text.
Description
When using layers, the default domain center is [0,0,0] meaning that the domain needs to be above the surface. Changing DFN.params['domainCenter'] does not seem to change the actual domain center. For example,
DFN.params['domainSize']['value'] = [200.0, 200.0, 60.0]
DFN.params['domainCenter']['value'] = [0, 0, -30]
DFN.params['numOfLayers']['value'] = 3
DFN.params['layers']['value'] = [
[-20, 0],
[-40.0, -20.0],
[-60.0, -40.0],
]
print(DFN.params['domainCenter']['value'])
exit()
console output is:
[0, 0, 0]
rather than [0,0,-30], so the domain has to be made as
DFN.params['layers']['value'] = [
[10, 30],
[-10.0, 10.0],
[-30.0, -10.0],
- Dominant language
- Python
- Stars
- 97
- Forks
- 55
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lanl/dfnWorks
-
Replace legacy VTK output with XML VTU/PVD across dfnWorksMay be free again @hymanjd claimed this 111 days ago, and no pull request is open. Open
-
Add Mesh Parameter ChecksMay be free again @hymanjd claimed this 431 days ago, and no pull request is open. Open
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Indexing error when fractures are rejectedMay be free again @hymanjd claimed this 616 days ago, and no pull request is open. Open
-
Can't run particle tracking after pruning is completeMay be free again @hymanjd claimed this 713 days ago, and no pull request is open. Open
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
epam/ai-dial-quickapps-backend#628 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 Under an hour Newbie friendliness 69/100
timqian/chinese-independent-blogs#2235 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
eclipse-score/coverage_tool#27 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
bojieli/ai-agent-book#1174 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
RedHatQE/mtv-api-tests#721 ·
Maintainers usually reply within 1 day