bug: main does not compile, MinHash calls build_prefilter without the metrics argument
Maintainers usually reply within 2 days
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- build-system
Research direction
The issue is in rust/lance/src/io/exec/minhash.rs at line 235, where build_prefilter is called with six arguments instead of seven. Look at the function signature in rust/lance/src/io/exec/utils.rs:370 to see the required parameters. Examine how rust/lance/src/io/exec/fts.rs passes the metrics argument and replicate that. After making the change, run the Rust compiler to verify the build succeeds.
Written by the indexing model from the issue text.
Description
main at 6f843df81 does not compile. build_prefilter takes seven parameters, the last one metrics: &ExecutionPlanMetricsSet (rust/lance/src/io/exec/utils.rs:370), while the call site added for the MinHash scalar index passes six (rust/lance/src/io/exec/minhash.rs:235):
error[E0061]: this function takes 7 arguments but 6 arguments were supplied
--> rust/lance/src/io/exec/minhash.rs:235
error: could not compile `lance` (lib) due to 1 previous error
pub mod minhash; is declared unconditionally in rust/lance/src/io/exec/mod.rs:18, so every default build hits it: linux-build, windows, the Java jobs, the Python wheels, clippy and rustdoc all fail on PRs that merge current main.
The two changes are individually fine and conflict only semantically, so git merged both without a textual conflict:
- #9471 added the
metricsparameter and updated the call sites that existed at the time. - #9114 added
minhash.rswith a newbuild_prefiltercall, branched before #9471.
The fix is to pass a metrics set at that call site the way rust/lance/src/io/exec/fts.rs does.
Worth noting separately: nothing caught this before merge, because branch protection tests each PR against its own base rather than against the merge result. A merge-queue or a required rebase would have.
- Dominant language
- Rust
- Stars
- 7.2k
- Forks
- 882
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 241
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lance-format/lance
-
bug: all-empty index keeps lowest dataset_version segment instead of earliest created_atPossibly taken @ump45nose claimed this 1 day ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lance-format/lance#10097 ·
Maintainers usually reply within 2 days
-
perf: miniblock binary decode copies the chunk's value bytes instead of slicing themPossibly taken @LuciferYang claimed this 5 days ago. Openperformance
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
lance-format/lance#9928 ·
Maintainers usually reply within 2 days
-
After initialize_mem_wal, every FTS query logs "ERROR Index __lance_mem_wal has no fields"Possibly taken @lance-gatefixer claimed this 16 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
lance-format/lance#9655 ·
Maintainers usually reply within 2 days
-
perf: mapping row offsets rescans the fragment for every offset when deletions are set-backedPossibly taken @LuciferYang claimed this 25 days ago. Openperformance
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
lance-format/lance#9498 ·
Maintainers usually reply within 2 days
-
bug: weighted k-means pads the partition count with duplicate clusters, leaving them permanently emptyPossibly taken @LuciferYang claimed this 31 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
lance-format/lance#9345 ·
Maintainers usually reply within 2 days
All issues in lance-format/lance
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
521xueweihan/HelloGitHub#4023 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
nautechsystems/nautilus_trader#5365 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
IntersectMBO/developer-experience#347 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
registrystack/registry-stack#2168 ·
Maintainers usually reply within 1 day
-
bug crate: 3d help wanted triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
kornia/kornia-rs#1203 · 1 comment ·
Maintainers usually reply within 1 day