reqwest client: use aws-lc-rs instead of ring for TLS
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 45/100
Research direction
Start with the generator config in rust/reqwest-client.toml, where the rustls-tls-native-roots feature is enabled, then check the matching dependency in rust/lance-namespace-reqwest-client/Cargo.toml. The issue suggests generating against reqwest 0.13 with its rustls feature, so confirm that the generator supports that version first. Done means the generated crate no longer pulls in ring (check with cargo tree -i ring) and it still builds. Expect to ask the maintainers whether the reqwest upgrade is wanted before changing the generator.
Written by the indexing model from the issue text.
Description
The generated lance-namespace-reqwest-client (rust/reqwest-client.toml, rust/lance-namespace-reqwest-client/Cargo.toml) enables reqwest 0.12's rustls-tls-native-roots feature, which turns on rustls's ring crypto provider. Cargo merges features across a crate's dependents, so ring is linked into every downstream build, including LanceDB's Python and Node packages, even though everything else there uses aws-lc-rs.
Suggested fix: generate against reqwest 0.13 and use its rustls feature, which uses aws-lc-rs.
Related: lance-format/lance#9855 (same change for lance-namespace-impls).
- Dominant language
- Java
- Stars
- 59
- Forks
- 51
- Avg merge
- 19m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lance-format/lance-namespace
-
Avoid generating .iml files when packaging java projects with Intellij IdeaPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 1/5 Under an hour Newbie friendliness 65/100
lance-format/lance-namespace#273 ·
-
Do not depend on the lance default featuresPossibly taken @valkum claimed this 374 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
lance-format/lance-namespace#240 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
lance-format/lance-namespace#365 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 64/100
lance-format/lance-namespace#364 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
lance-format/lance-namespace#342 ·
All issues in lance-format/lance-namespace
Similar issues
-
staticAssetsPath follows symlinks outside the directory on WindowsPossibly taken @ybelMekk claimed this today. Openbug security findings
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
navikt/mock-oauth2-server#1132 ·
Maintainers usually reply within 1 day
-
agent:working follow-up
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Sanne/incus-spawn#1683 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
checkstyle/checkstyle#22210 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
google/error-prone#6239 · 1 comment ·
Maintainers usually reply within 1 day
-
[Failing Test]: BigqueryClient.queryUnflattened fails BigQuery ITs on a transient 503Possibly taken @mxtymoshyk claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day