nit: several low-priority polish items in JSON parser (decimal rendering, ordering invariant, docstrings)
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Domain
- compilers
Research direction
Read the three named areas first: cli/LckJsonFmt.lean:30, Lck/Json/Syntax.lean:444-450, and Lck/Json/Parser.lean. Separate the precision, ordering-invariant, and documentation proposals before deciding their scope; done would require an agreed resolution for each listed item, including the API-visibility question for convOfPolicy.
Written by the indexing model from the issue text.
Description
Items
These are low-priority nits flagged by AI code review on PR #8. Grouping them into a single issue to keep the tracker clean.
1. Decimal rendering precision (cli/LckJsonFmt.lean:30)
The renderNumber function may truncate fractional digits beyond 20 decimal places, losing round-trip fidelity for numbers with high precision.
2. Dependent types for ordering invariant (Lck/Json/Syntax.lean:444-450)
SortedKVs currently enforces its key-sorted ordering invariant by convention. Using dependent types (a sigma type or a subtype with a Sorted proof) would make the invariant enforcement compile-time rather than runtime.
3. Missing docstrings (Lck/Json/Parser.lean)
convOfPolicy: no docstring explaining what it does or why it existsSortedKVs.ofList: no documentation of the byte-lexicographic key ordering behavior- Consider making
convOfPolicyprivateto reduce public API surface
References
- Flagged by AI code review on PR #8
- Dominant language
- Lean
- Stars
- 2
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lambdaclass/lambda_compiler_kit
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
All issues in lambdaclass/lambda_compiler_kit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
internal.h中，漏掉了1个定义。 Open
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
oxc-project/oxc#26944 ·