nit: fix misleading traversal-order comments in Syntax.lean and Parser.lean
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 68/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Stale
- Domain
- compilers
Research direction
Start by reading the comments at Lck/Json/Syntax.lean:151-153 and Lck/Json/Parser.lean:68-70, then compare them with the traversal implementation. Update both comments to state that processing is tail-first, in right-to-left order. The issue is done when the comments accurately match the implementation.
Written by the indexing model from the issue text.
Description
Problem
Comments in Lck/Json/Syntax.lean:151-153 and Lck/Json/Parser.lean:68-70 describe traversal order inaccurately. The actual traversal is right-to-left (tail processed first), but the comments do not reflect this.
Expected fix
Update the comments to accurately describe that elements are processed tail-first (right-to-left order), matching the actual implementation.
References
- Flagged by AI code review on PR #8
- Dominant language
- Lean
- Stars
- 2
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lambdaclass/lambda_compiler_kit
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
-
Difficulty 1/5 Under an hour Newbie friendliness 55/100
All issues in lambdaclass/lambda_compiler_kit
Similar issues
-
flang:fir-hlfir
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
llvm/llvm-project#225935 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
objectionary/eo#8923 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Coarray integration tests carry no LABELS, so run_tests.py silently skips them under every backend Opencoarray
Difficulty 2/5 1-3 hours Newbie friendliness 70/100