commit_session endpoint uses QueryParam — optional body fields silently ignored
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Start in handler.py at the POST /session/{session_name}/commit handler and compare its parameter parsing with the issue description. Then inspect client/v2/domains/session.py and the related session endpoints; done means JSON body values for login_session_token and filename are validated and sent through the client rather than silently ignored as query parameters.
Written by the indexing model from the issue text.
Description
Same regression as BA-5496. POST /session/{session_name}/commit handler uses QueryParam[CommitSessionRequest] instead of BodyParam.
All fields are optional (login_session_token, filename), so validation passes with empty query params — no 400 error. However, if clients send these values in the JSON body (e.g. WebUI), they are silently ignored because the handler only reads from query string.
Root cause: BA-4823 (PR #9588, fc0caf8eb) bulk-changed BodyParam to QueryParam for multiple session endpoints.
Fix:
-
handler.py: Change QueryParam[CommitSessionRequest] to BodyParam[CommitSessionRequest], update query.parsed to body.parsed
-
client/v2/domains/session.py: Change params= back to request= in commit_session method
Related: BA-5496 (rename_session), BA-5497 (convert_session_to_image)
JIRA Issue: BA-5511
- Dominant language
- Python
- Stars
- 670
- Forks
- 183
- Avg merge
- 20h 35m
- Merged PRs (30d)
- 429
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from lablup/backend.ai
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
lablup/backend.ai#14890 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
lablup/backend.ai#14886 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
lablup/backend.ai#14485 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
lablup/backend.ai#14101 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
lablup/backend.ai#14080 ·
All issues in lablup/backend.ai
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100