Wire the RBAC validators into relation actions

Open Beginner friendly
#14,080 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python

Research direction

Start at composer.py:419-422 and compare the empty validator slot with actions/v2/relation/validator/rbac.py. Wire the existing RBAC validator into the relation action composition, then add a composition test that fails if the slot is empty. Done means relation actions include the permission validator and the test protects that wiring.

Written by the indexing model from the issue text.

Description

The relation validator exists but the composer leaves its slot empty, so relation actions run without any permission check (composer.py:419-422, actions/v2/relation/validator/rbac.py). Wire it and pin the wiring with a composition test so an empty slot cannot recur.

JIRA Issue: BA-7556

Dominant language
Python
Stars
670
Forks
183
Avg merge
20h 35m
Merged PRs (30d)
429

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from lablup/backend.ai

All issues in lablup/backend.ai

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.