chore: clean up stale LogicPlatform references after ClusterLogicPlatform rename
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 79/100
Research direction
Read the PROJECT resource entry and the named comments in api/v1/platform_types.go and api/v1/status_types.go; check api/v1/clusterlogicplatform_types.go for the cluster scope marker. Update the stale resource name, scope, and comment references, then run make generate manifests and confirm it produces no unexpected diff.
Written by the indexing model from the issue text.
Description
After #89 replaced LogicPlatform with ClusterLogicPlatform, a few references to the old name and field paths were left behind.
Inconsistencies
1. PROJECT still lists LogicPlatform
PROJECThas a resource entry withkind: LogicPlatformandnamespaced: true.- There is no entry for `ClusterLogicPlatform`, which is cluster-scoped (`+kubebuilder:resource:scope=Cluster` in
api/v1/clusterlogicplatform_types.go).
Fix: Replace the entry with kind: ClusterLogicPlatform and namespaced: false.
2. Stale comments in api/v1/platform_types.go
- L65:
The DaemonSet is deployed 1:1 per LogicPlatform ... - L228:
There is a 1:1 relationship between LogicPlatform and the Vector DaemonSet. - L298:
Populated only when spec.workflowGateway.ingress.enabled .... The field isspec.gateway(`json:"gateway"`).
3. Stale comments in `api/v1/status_types.go`
- L62:
// LogicPlatform conditions - L74:
// LogicPlatform reasons
Acceptance criteria
-
PROJECTdescribesClusterLogicPlatform\as a cluster-scoped resource - No comments under
api/refer toLogicPlatform(other thanClusterLogicPlatform) orspec.workflowGateway -
make generate manifestsproduces no unexpected diff
- Dominant language
- Go
- Stars
- 3
- Forks
- 3
- Avg merge
- 1d 12m
- Merged PRs (30d)
- 18
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from kubesmarts/logic-operator
-
README gateway ingress example uses `className` instead of `ingressClassName`Possibly taken @mathecruz claimed this today. Opendocumentation
kubesmarts/logic-operator#99 · 1 assignee ·
Maintainers usually reply within 1 day
-
area/operator
Difficulty 4/5 3-5 days Newbie friendliness 48/100
kubesmarts/logic-operator#88 ·
Maintainers usually reply within 1 day
-
Secure /v1/definitions on the workflow gateway (OIDC / API_KEY + Kubernetes auth)Possibly taken @ricardozanini claimed this 17 days ago. Openarea/gateway enhancement
kubesmarts/logic-operator#84 · 1 assignee ·
Maintainers usually reply within 1 day
-
area/gateway
Difficulty 5/5 Over a week Newbie friendliness 35/100
kubesmarts/logic-operator#79 ·
Maintainers usually reply within 1 day
-
area/operator
Difficulty 5/5 Over a week Newbie friendliness 35/100
kubesmarts/logic-operator#77 ·
Maintainers usually reply within 1 day
All issues in kubesmarts/logic-operator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
karmada-io/karmada#8101 ·
Maintainers usually reply within 1 day
-
product:platform
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Infisical/infisical#9746 · 1 comment ·
Maintainers usually reply within 1 day
-
CrossEntropyFilter raises on zero probabilities and single-class resultsPossibly taken @NopeCharon claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
txn2/mcp-data-platform#2728 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Windshiftapp/core#542 ·
Maintainers usually reply within 1 day