Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

cmd: subscribe silently ignores malformed --filter values

Closed
  • Is something wrong?
#3,941 1 comment 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 5 days

@axhatggg is already working on this.

Since Sep 2, 2026.

Assessment

This issue has not been assessed yet.

Description

Problem

func subscribe --filter expects filters in key=value form, but malformed values are currently printed and ignored instead of returning an error.

For example:

func subscribe --filter badfilter

prints Invalid pair: badfilter, continues, and can still write subscription config without the intended filter.

Expected behavior

Malformed filters should fail before func.yaml is changed. Valid values containing = should still be preserved, for example --filter foo=bar=baz should store key foo with value bar=baz.

Suggested fix

Return an error for missing = or an empty key, and add regression tests for malformed filters and values containing =.

Dominant language
Go
Stars
365
Forks
223
Avg merge
3d 7h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from knative/func

All issues in knative/func

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.