test: unit tests are placeholders and CI runs on Node 18
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 38/100
Research direction
Start by reading __tests__/server.test.js and the “Server API tests” workflow to see the existing test setup and Node version. The issue proposes exercising the exported app with Supertest and mongodb-memory-server across auth, enrolment, payments and reviews, then updating CI to Node 22. Done means replacing placeholder checks with the listed integration cases and updating the workflow; branch protection is also requested.
Written by the indexing model from the issue text.
Description
__tests__/server.test.js checks things like 2 + 2 === 4 and string operations, so the "Server API tests" workflow passes without exercising any controller or route. Only trie.test.js tests real code. The workflow also runs on Node 18.x, which is end-of-life.
Suggested fix
- Add integration tests with Supertest against the exported app and an in-memory MongoDB (
mongodb-memory-server) for auth, enrolment, payments and reviews: the happy path plus 401/403, not-owner, invalid input, missing ids and duplicates. - Run the workflow on Node 22 LTS and make it a required check for
main.
Found while reviewing StudyNotion with Claude Code.
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 8
- Avg merge
- 11m
- Merged PRs (30d)
- 4
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from khemssharma/StudyNotion
-
docs: README is missing the sections its introduction promises; outdated clone URL and Node versionOpendocumentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
khemssharma/StudyNotion#55 ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
khemssharma/StudyNotion#59 ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 45/100
khemssharma/StudyNotion#58 ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 45/100
khemssharma/StudyNotion#56 ·
-
documentation
Difficulty 4/5 3-5 days Newbie friendliness 48/100
khemssharma/StudyNotion#54 ·
All issues in khemssharma/StudyNotion
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
OWASP/CheatSheetSeries#3018 ·
Maintainers usually reply within 1 day
-
Radix number block generates NaN after switching a negative or decimal number to binary, octal or hexPossibly taken @matthewalberto claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
mit-cml/appinventor-sources#4246 · 1 comment ·
Maintainers usually reply within 1 day
-
marketing
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 83/100
GoogleChrome/modern-web-guidance-src#3675 · 2 comments ·
Maintainers usually reply within 1 day