Don't add the provider's public host to egress when a ModelConfig sets baseUrl
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 81/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- go
- Domain
- networking, security
Research direction
Start with adkconfig/builder.go lines 312–318 and compare how Mistral and Ollama handle a configured baseUrl. Update the OpenAI, Anthropic, and Google provider egress logic to match that behavior, then check the relevant tests or add coverage for configured and default URLs. Done means a custom base URL does not add the provider’s public host to egress.
Written by the indexing model from the issue text.
Description
adkconfig/builder.go:312-318 (v1.0.0-rc1) always appends api.openai.com, api.anthropic.com or generativelanguage.googleapis.com to an actor's egress for those providers, even when baseUrl points at an in-cluster proxy (LiteLLM for us). So every actor's allowlist includes a public endpoint it never needs, and we have to block it with a network policy at the egress gateway.
Mistral and Ollama already skip the default when a base URL is set; doing the same for the others would be a small change, and we're happy to PR it.
- Dominant language
- Go
- Stars
- 4.1k
- Forks
- 871
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 183
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from kagent-dev/kagent
-
skills-init: commit-SHA skill refs never start (git checkout -- <sha> reads the SHA as a pathspec)Open
Difficulty 1/5 Under an hour Newbie friendliness 84/100
kagent-dev/kagent#3571 ·
Maintainers usually reply within 1 day
-
Gemini catalogs omit gemini-4-argon and gemini-3.8-flashPossibly taken @jayunit100 claimed this 3 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
kagent-dev/kagent#3524 · 1 comment ·
Maintainers usually reply within 1 day
-
[BUG] OpenAI and Ollama adapters send an empty tool message when a tool returns a dictPossibly taken @helloxjade claimed this 6 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
kagent-dev/kagent#3462 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
kagent-dev/kagent#3428 · 1 comment ·
Maintainers usually reply within 1 day
-
[BUG]Possibly taken @helloxjade claimed this 10 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
kagent-dev/kagent#3385 · 1 comment ·
Maintainers usually reply within 1 day
All issues in kagent-dev/kagent
Similar issues
-
agent-butler-finding chore
Difficulty 1/5 Under an hour Newbie friendliness 88/100
jordansmall/spindrift#6695 ·
Maintainers usually reply within 1 day
-
book-layout.spec fails when the similar-books rail holds other projects' booksPossibly taken @praetorianer777 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
praetorianer777/GoTome#373 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
/shutdown/ready can fail to return an HTTP response when readiness takes longer than the server write timeoutPossibly taken @floriankoch claimed this today. Opentriage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
envoyproxy/gateway#10562 ·
Maintainers usually reply within 1 day
-
Adding an LDAP group reports every search failure as "LDAP Group DN is not found"Possibly taken @Daksha1611 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day