Test what each browser-check step does in a browser
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 57/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript, node.js, playwright
Research direction
Start with the existing tests in contributing/test/browse.test.mjs and its opening note, then read contributing/lib/browse.mjs to understand --plan and how browser runs are started. Add Chromium-only tests using the small sample and Playwright to cover the listed browser actions and outputs, including the shot in shots/index.md; Safari can remain a manual check. Done when the browser behavior, failures and run setup are covered by tests.
Written by the indexing model from the issue text.
Description
contributing/lib/browse.mjs runs a review's steps in every browser and theme: clicks, taps, drags, typing, waits and shots, in Chromium, Firefox, WebKit and Safari Technology Preview. Its options, the runs they expand into, where a step acts, and the check that each step is one action are tested in contributing/test/browse.test.mjs, without a browser, using its --plan mode. What each step does in a browser isn't tested at all.
What's untested:
- each action in a browser:
click,tap,drag(touch and mouse),type,press,wait,until,eval,console,shotandsleep; - Safari's WebDriver path, including that it treats a frame's name as the page's frame;
shots/index.md, the names it gives shots, and its exit codes: 1 for a failed step, 4 for a run that couldn't start;- the theme steps it adds, and the scratch copy of the folder it serves;
--devpassed on to reader;- the step and whole-run timeouts, and stopping cleanly on Ctrl-C.
Suggested start: a test that runs browse.mjs in Chromium alone (Playwright is a dev dependency) on a small sample, with one step of each kind, and checks what it prints and the shot it writes. The tests already in browse.test.mjs show the pattern, and its opening note says how to add one. Safari's path can stay a manual check, as it runs only outside the sandbox.
Found in the 0.0.5 release review (#81).
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 1
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 26
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jzheaux/reader
-
polish
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
accessibility bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
polish
Difficulty 3/5 1-2 days Newbie friendliness 64/100
Maintainers usually reply within 1 day
Similar issues
-
Radix number block generates NaN after switching a negative or decimal number to binary, octal or hexPossibly taken @matthewalberto claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
mit-cml/appinventor-sources#4246 · 1 comment ·
Maintainers usually reply within 1 day
-
marketing
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
accessibility good first issue languages
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 2 days
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 78/100