t/concur fails

Open
#67 0 comments 0 reactions 1 assignee View on GitHub

@malcolmsparks is already working on this.

Since Nov 4, 2019.

Assessment

This issue has not been assessed yet.

Description

interval-calculus
(t/concur
  #:tick{:beginning #time/instant"2000-01-01T01:00:01.011Z", :end #time/instant"2000-01-01T02:00:01.011Z"}
  #:tick{:beginning #time/instant"2000-01-01T00:00:00.003Z", :end #time/instant"2000-01-01T01:00:00.003Z"}
  #:tick{:beginning #time/instant"2000-01-01T01:00:01.179Z", :end #time/instant"2000-01-01T02:00:01.179Z"})

Fails with:

No implementation of method: :< of protocol: #'tick.core/ITimeComparison found for class: nil

Because: tick.interval/relation cannot handle nil, which it will get in the example above.

I worked around it by doing:

(defn safe-concur
  ([] nil)
  ([x] x)
  ([x & args]
   (reduce
     (fn safe-concur-check [x y]
       (and
         (and x y)
         (tick.interval/concur x y)))
     x args)))
Dominant language
Clojure
Stars
646
Forks
61
Avg merge
17h 42m
Merged PRs (30d)
1

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from juxt/tick

All issues in juxt/tick

Similar issues

More Clojure issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.