A late screenshot response can complete the next request
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 56/100
Research direction
Read InjectionServer.swift around requestScreenshot (lines 91–122) and the .screenshotData handler (lines 272–280). Trace what happens when request A times out, request B starts, and A’s delayed response arrives; then verify that responses cannot complete the wrong request, including with a test or reproduction of that sequence.
Written by the indexing model from the issue text.
Description
requestScreenshot clears pendingScreenshot after its timeout. The .screenshotData handler then assigns any received screenshot to whichever request is pending.
The problematic sequence is: request A times out; request B starts; A's delayed response arrives. B is signalled with A's image and returns it as its own result. B's actual response can then be discarded or incorrectly satisfy another request.
Please correlate screenshot responses with their requests, or prevent reuse of the pending slot until the old response has been drained. This is a code-level finding; I haven't reproduced this timing in the app.
- Dominant language
- Swift
- Stars
- 437
- Forks
- 32
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from johnno1962/InjectionNext
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
johnno1962/InjectionNext#175 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
johnno1962/InjectionNext#167 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
johnno1962/InjectionNext#147 · 1 comment ·
-
Issue injecting on real device – Code signature invalid & Unhide Symbols restart loopMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 38/100
johnno1962/InjectionNext#81 · 18 comments · 2 reactions ·
All issues in johnno1962/InjectionNext
Similar issues
-
area:ui enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
s3onghyun/bulchimbeon#22 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
[BUG] File transcription skips audio chunks shorter than one secondPossibly taken @sabbah13 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
altic-dev/FluidVoice#1161 ·
Maintainers usually reply within 1 day
-
swift.md: `Date(myString, strategy: .iso8601)` example omits `try` — the initializer is throwingOpen
Difficulty 1/5 Under an hour Newbie friendliness 88/100