Need help to understand how transition works

Open
#59 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, react-native
Domain
frontend, mobile

Research direction

Start by reproducing the Router configuration shown in the issue, comparing the working TabsRoute transition with navigation from Topics to /topics/:topicId. Confirm whether the horizontal-card-stack transition is applied when opening Topic, and document the configuration or behavior needed for the requested transition.

Written by the indexing model from the issue text.

Description

I have a regular Tabs interface, and I want to slide between tabs (this one works).
But when I click for example on a Topic in Topics Tab, I want to go in topics/:topicId with a horizontal-card-stack (this one is not working).

Am I doing something wrong ?

    <Router
      history={nativeHistory}
      addressBar
    >
      <TabsRoute
        path="/home"
        component={Master}
        onEnter={userIsLogged}
        transition="horizontal-pager"
      >
        <Route
          path="/"
          component={Topics}
        />
        <Route
          path="/favorites"
          component={Favorites}
        />
        <Route
          path="/profile"
          component={Profile}
        />
        <Route
          path="/more"
          component={More}
        />
      </TabsRoute>
      <Route
        path="/topics/:topicId"
        component={Topic}
        transition="horizontal-card-stack"
      />
      <Route
        path="/questions/:questionId"
        component={Question}
        transition="horizontal-card-stack"
      />
      <Route
        path="/login"
        component={Login}
        onEnter={userIsNotLogged}
      />
    </Router>
Dominant language
JavaScript
Stars
636
Forks
37
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jmurzy/react-router-native

All issues in jmurzy/react-router-native

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.