Missing file error on 'make install'
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cmake, cpp
- Domain
- build-system
Research direction
Start with thirdparty/internal_deps.cmake and reproduce the failure with make install using internal dependencies. Check how the fetched dependency source paths are resolved for the four nonstd headers, then verify that installation succeeds with version 1.3.2 and the headers are placed under the configured include destination.
Written by the indexing model from the issue text.
Description
I use internal deps, and make install fails due to some missing files in thirdparty (with version 1.3.2, dependencies are no more in submodules).
I had to apply the following patch.
I'm not used enough to cmake to know if there are variables that could be used to get the src dir of the fetched dependencies.
diff --git a/thirdparty/internal_deps.cmake b/thirdparty/internal_deps.cmake
index 44f0446..0976c8c 100644
--- a/thirdparty/internal_deps.cmake
+++ b/thirdparty/internal_deps.cmake
@@ -75,10 +75,10 @@ if (JINJA2CPP_BUILD_TESTS)
endif()
install (FILES
- thirdparty/nonstd/expected-lite/include/nonstd/expected.hpp
- thirdparty/nonstd/variant-lite/include/nonstd/variant.hpp
- thirdparty/nonstd/optional-lite/include/nonstd/optional.hpp
- thirdparty/nonstd/string-view-lite/include/nonstd/string_view.hpp
+ ${FETCHCONTENT_BASE_DIR}/expected-lite-src/include/nonstd/expected.hpp
+ ${FETCHCONTENT_BASE_DIR}/variant-lite-src/include/nonstd/variant.hpp
+ ${FETCHCONTENT_BASE_DIR}/optional-lite-src/include/nonstd/optional.hpp
+ ${FETCHCONTENT_BASE_DIR}/string-view-lite-src/include/nonstd/string_view.hpp
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/nonstd)
install (TARGETS RapidJson
- Dominant language
- C++
- Stars
- 602
- Forks
- 115
- Avg merge
- 2h 34m
- Merged PRs (30d)
- 317
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jinja2cpp/Jinja2Cpp
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
jinja2cpp/Jinja2Cpp#395 · 20 comments ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 74/100
Maintainers usually reply within 1 day
All issues in jinja2cpp/Jinja2Cpp
Similar issues
-
v9.6.0: CMake incorrectly enforces presence of libevdevPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Rowan (2017) electron heating gives NaN for beta > beta_max; clip() then sets electrons to kel_minOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
parthenon-hpc-lab/kharma#213 · 1 comment ·
Maintainers usually reply within 3 days
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
metasequoiaime/msime#9113 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
tone-3000/tone3000-plugin#257 · 1 comment ·
Maintainers usually reply within 1 day
-
Locked plugin flip-flops position on every refresh after being disabledPossibly taken @Illustar0 claimed this today. Openissue report
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ModOrganizer2/modorganizer#2449 ·