Add units to the configuration parameter: "pageFormat"

Open
#4,559 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
javascript
Domain
frontend

Research direction

Start by locating the JSON configuration handling for pageFormat and the existing grid and ruler unit settings. Trace how those settings affect snapping and display, then verify that a configured millimeter unit is applied consistently across the editor.

Written by the indexing model from the issue text.

Description

notstale
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Hi, within the json configuration, there is a parameter pageFormat, but it is hardcoded in inches. So when a user wants to switch the drawio into milimeters, he can e.g. set the grid rulers into milimeters, but not the grid size. That creates an unpleasant schism, when rulers are indeed in milimeters, but the shapes still snap to inches.

Please, add the possibility to change the entire global app's unit settings into milimeters, so that non-US folks can work in it as well.

A good start seems to be the pageFormat parameter, which could include the unit sub-parameter.

Thank you for consideration 😊

Dominant language
JavaScript
Stars
9.4k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jgraph/drawio

All issues in jgraph/drawio

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.