fix(observability): self-improve.sh review 门三重 fail-open——脚本失败/解析失败/缺键都静默判 approve
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- cli, observability
Research direction
Read .dev/scripts/self-improve.sh around lines 1134–1135 and compare its fallback behavior with the visible marker in review-changes.sh around line 170. Decide whether to add observable failure handling or document the deprecated script’s warning, as the issue permits either. Done when failures, parse errors, and a missing verdict no longer silently approve, or the risk is explicitly recorded.
Written by the indexing model from the issue text.
Description
fix(observability): self-improve.sh review 门三重 fail-open——脚本失败/解析失败/缺键都静默判 approve
优先级 P3(脚本已 deprecated,留档修) · 依赖：无
基线 HEAD = 880cff08(wt-b2,Goal 428 S4 扫描批)。来源:Goal 428 S4 全仓静默降级扫描,登记页 docs/architecture/degradation-registry.md。owner ruling:「任何降级必须可观测」;fail-open 门是裁决点名的违例形态。
Summary
.dev/scripts/self-improve.sh:1134:REVIEW_JSON=$(…review-changes.sh … 2>/dev/null || echo '{"verdict":"approve"}')——review 脚本挂掉(provider 挂/崩溃/非 JSON)被换成一个 approve。:1135:解析失败或缺 verdict 键同样默认 approve(第三重)。- review-changes.sh 内层 fallback(:170)至少留了可见 marker(「could not be parsed…defaulting to approve」,confidence 0.5);外两层全静默。
- 缓解:该脚本已 deprecated(parallel-self-improve.sh 取代),但留档即活口——v1/v2 引擎若回退引用同型逻辑,口子随行。
建议
修法(若保留脚本):fail 臂改 request_changes 或显式中止并 echo 到日志;至少去掉 2>/dev/null、fail-open 臂打 [review-gate] FALL-OPEN 行。deprecated 现状下可仅登记+在此留警示,不动脚本。
- Dominant language
- Rust
- Stars
- 4
- Forks
- 0
- Avg merge
- 3h 55m
- Merged PRs (30d)
- 11
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jeffkit/recursive
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
jeffkit/recursive#86 · 16 comments ·
Maintainers usually reply within 1 day
All issues in jeffkit/recursive
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
C-bug needs-triage O-UEFI T-libs
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug priority: P3 ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
shep-pm/shep-kelpie#1332 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
ramensoftware/windhawk#1156 · 2 comments ·
-
area/cli complexity:trivial good first issue Stellar Wave test
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Externalize-Labs/externalize#23 ·
Maintainers usually reply within 1 day