Producer: ignore .okf-write-*.tmp orphans in RequireEmpty, pruning and the staging commit
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 62/100
Research direction
Start in producers/ at BundleWriter.cs: RequireEmpty near line 70, the empty-directory pruning around lines 896-904, and CommitStaging around line 1402, which enumerates staging files with EnumerateFiles(staging, "*"). Find where the .okf-write-*.tmp pattern is defined in FileSystemBundleProvider so the orphan check matches it. Done means all three sites ignore orphans without deleting them, with tests in OkfProducer.Tests run via dotnet test producers/OkfProducer.sln.
Written by the indexing model from the issue text.
Description
FileSystemBundleProvider can leave a .okf-write-<32hex>.tmp (crash, Windows ReplaceFile 1176/1177 under contention, BundleWriteOutcomeUnknownException). In producers/:
BundleWriter.cs:70(RequireEmpty,EnumerateFileSystemEntries().Any()) refuses a directory holding only such orphans;- empty-directory pruning (~
:896-904) keeps a directory that holds one; CommitStaging(~:1402,EnumerateFiles(staging, "*")) would copy an orphan left in staging into the bundle.
Decide per site: ignore and report it (never delete: it may be the only copy of the new content, as the provider's docs say) and skip it in CommitStaging. Tests in OkfProducer.Tests; producers/ is outside CI, run dotnet test producers/OkfProducer.sln locally.
Follow-up of #157, found by the audit.
- Dominant language
- C#
- Stars
- 4
- Forks
- 1
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 32
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jchable/okf4net
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
.NET bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
test
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 1/5 Under an hour Newbie friendliness 82/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area/backend type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
umbraco/Umbraco-CMS#24668 · 1 comment ·
Maintainers usually reply within 1 day
-
Pri3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
MicrosoftDocs/windows-dev-docs#6205 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
area-ai untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dotnet/extensions#7956 ·
Maintainers usually reply within 1 day