Unnecessary synchronisation?
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- operating-systems
Research direction
Start in src/com/sun/jna/NativeLibrary.java at lines 186-188 and inspect how searchPaths, the ConcurrentHashMap, and the synchronized block are used there. Determine whether the synchronization is needed and whether the update target is correct; the work is done when the synchronization behavior is justified and the relevant existing behavior remains intact.
Written by the indexing model from the issue text.
Description
The synch. here appears to be unnecessary:
https://github.com/java-native-access/jna/blob/365629530635440381f63939f7891456992fe91b/src/com/sun/jna/NativeLibrary.java#L186-L188
searchPaths is a ConcurrentHashMap, so does it need synch?
It also does not make sense to me to synch. on the value being added, rather than the target being updated.
- Dominant language
- Java
- Stars
- 8.9k
- Forks
- 1.7k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from java-native-access/jna
-
Difficulty 4/5 1-2 days Newbie friendliness 48/100
java-native-access/jna#1742 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 66/100
java-native-access/jna#1738 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
java-native-access/jna#1736 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
java-native-access/jna#1717 ·
-
Windows32Exception - The parameter is incorrectPossibly taken @marktech0813 claimed this 335 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
java-native-access/jna#1700 · 11 comments ·
All issues in java-native-access/jna
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
apache/rocketmq-dashboard#6331 ·
Maintainers usually reply within 5 days
-
status: team-only type: dependency-upgrade
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
spring-projects/spring-boot#52143 · 1 comment ·
Maintainers usually reply within 1 day
-
area/frontend good first issue kind/cooldown
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
kestra-io/kestra#20704 · 1 comment ·
Maintainers usually reply within 1 day