Passing same buffer as two method arguments does not read back modified content
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with the JNA call path for the do_something(ByteBuffer out, ByteBuffer in) entry point and the handling of heap-backed ByteBuffer arguments. Reproduce the call with the same buffer passed for both parameters on JNA 5.5.0, then verify that the modified output remains visible after the native function returns.
Written by the indexing model from the issue text.
Description
Assume the following native library function, which reads from in and writes to out:
int do_something(void *out, void *in);
mapped to the following interface in Jave:
public interface mylibrary extends Library {
public int do_something(ByteBuffer out, ByteBuffer in);
}
When calling this function with the same buffer backed by a heap-allocated array as both output and input argument, i.e.:
public void process(ByteBuf buffer) {
// buffer is backed by heap-allocated array
mylibraryInstance.do_something(buffer, buffer);
}
then the buffer will not be updated to reflect the content that was written to out within the native function implementation.
I assume this is because each argument will be processed individually, the buffer will be copied two times into native memory, both instances will be read back after the function call and the second argument (in, unmodified) replaces the first argument (out, modified & expected content).
Workaround: Create a new buffer before calling the native function (and write it back afterwards):
public void process(ByteBuf buffer) {
ByteBuffer outputBuffer = ByteBuffer.allocate(buffer.remaining());
outputBuffer.limit(buffer.remaining());
mylibraryInstance.do_something(outputBuffer, buffer);
// here, outputBuffer has the expected (modified) content - write back to original buffer
}
Version of JNA and related jars: jna 5.5.0 and jna-platform 5.5.0
Version and vendor of the java virtual machine: Oracle JDK 12.0.2
- Dominant language
- Java
- Stars
- 8.9k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from java-native-access/jna
-
Incorrect mapping of c.s.j.platform.unix.solaris.LibKstat.KstatCtlPossibly taken @dbwiddis claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
java-native-access/jna#1740 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 66/100
java-native-access/jna#1738 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
java-native-access/jna#1736 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
java-native-access/jna#1717 ·
-
Windows32Exception - The parameter is incorrectPossibly taken @marktech0813 claimed this 331 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
java-native-access/jna#1700 · 11 comments ·
All issues in java-native-access/jna
Similar issues
-
backend
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
bcgov/nr-forest-client#2524 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Sinytra/ForgifiedFabricAPI#298 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
team:Lumberjack
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
OpenLiberty/open-liberty#35998 ·
Maintainers usually reply within 1 day