Windows requires username passed to get_credential

Open
#688 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
security

Research direction

Search for WinVaultKeyring.get_credential and compare its signature and behavior with the base class, especially the default username=None. Confirm that omitting the username is accepted as described; add or update the relevant test if one is present nearby, then run the keyring test suite to verify the Windows behavior.

Written by the indexing model from the issue text.

Description

In https://github.com/jaraco/keyring/issues/668#issuecomment-2274273778, I learned that the WinVaultKeyring.get_credential doesn't honor the default username=None as indicated by the base class. It should.

Dominant language
Python
Stars
1.5k
Forks
208
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jaraco/keyring

All issues in jaraco/keyring

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.