ValueError when trying to download using DCC

Open
#198 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Start with the DCC receive example and the CTCP handling path shown in the traceback. Compare the parser's expected fields with the DCC SEND message in the report, then check existing DCC-related tests or examples. Done means a valid DCC SEND request is handled without the reported ValueError.

Written by the indexing model from the issue text.

Description

DEBUG:irc.client:command: privnotice, source: TS-APP|US|P|[email protected], target: <USERNAME>, arguments: ['** Sending you pack #169 ("Tangible.Software.Solutions.Java.to.Python.Converter.Premium.Edition.v21.8.31-DVT.tar"), which is 4.0MB. (resume supported)'], tags: None
DEBUG:irc.client:_dispatcher: privnotice
DEBUG:irc.client:FROM SERVER: :TS-APP|US|P|[email protected] PRIVMSG <USERNAME>:☺DCC SEND Tangible.Software.Solutions.Java.to.Python.Converter.Premium.Edition.v21.8.31-DVT.tar 1650529690 0 4157440 65☺
DEBUG:irc.client:_dispatcher: all_raw_messages
DEBUG:irc.client:command: ctcp, source: TS-APP|US|P|[email protected], target: <USERNAME>, arguments: ['DCC', 'SEND Tangible.Software.Solutions.Java.to.Python.Converter.Premium.Edition.v21.8.31-DVT.tar 1650529690 0 4157440 65'], tags: None
DEBUG:irc.client:_dispatcher: ctcp
Traceback (most recent call last):
  File "C:\Users\X\Documents\Programming\Projects\X\main.py", line 91, in <module>
    main()
  File "C:\Users\X\Documents\Programming\Projects\X\main.py", line 87, in main
    c.start()
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 1202, in start
    self.reactor.process_forever()
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 846, in process_forever
    consume(repeatfunc(one))
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\more_itertools\recipes.py", line 146, in consume
    deque(iterator, maxlen=0)
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 827, in process_once
    self.process_data(in_)
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 792, in process_data
    conn.process_data()
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 268, in process_data
    self._process_line(line)
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 299, in _process_line
    handler(arguments, command, source, tags)
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 329, in _handle_message
    self._handle_event(event)
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 376, in _handle_event
    self.reactor._handle_event(self, event)
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 922, in _handle_event
    result = handler.callback(connection, event)
  File "C:\Users\X\Documents\Programming\Projects\X\lib\site-packages\irc\client.py", line 1159, in _dispatcher
    method(connection, event)
  File "C:\Users\X\Documents\Programming\Projects\X\main.py", line 34, in on_ctcp
    command, filename, peer_address, peer_port, size = parts
ValueError: too many values to unpack (expected 5)

Using the DCC receive example with modified code:

def on_welcome(self, connection, event):
		self.connection.privmsg("NickServ", "IDENTIFY <PASS>")
		self.connection.join("#THE.SOURCE.NOSPAM")

	def on_privmsg(self, connection, event):
		self.connection.privmsg("TS-APP|US|P|39503", "xdcc send #169")
Dominant language
Python
Stars
422
Forks
91
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jaraco/irc

All issues in jaraco/irc

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.