[AIO] Registering a connection needs to be split out of connect()

Open
#189 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Start with AioConnection::connect() and compare the registration flow with the referenced heisenbridge/irc.py example around line 120. Determine whether registration should be optional during connect() or exposed as a separate register() call, then ensure CAP/SASL negotiation can occur before registration and document the accepted API behavior.

Written by the indexing model from the issue text.

Description

To implement CAP negotiations (for SASL) before registering a connection I had to split connection registration out of AioConnection::connect(): https://github.com/hifi/heisenbridge/blob/master/heisenbridge/irc.py#L120

My implementation is currently ugly but the requirement remains that registration needs to be split out either optionally (arg for connect to disable?) or by changing the API to require calling register() after connect().

I can PR an accepted solution.

Dominant language
Python
Stars
422
Forks
91
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from jaraco/irc

All issues in jaraco/irc

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.