jamesplease/react-request

Redundant `render` run with outdated state

Open

#196 opened on Sep 24, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (21 forks)github user discovery
help wantedrefactor

Repository metrics

Stars
 (358 stars)
PR merge metrics
 (PR metrics pending)

Description

If I render the same Fetch with new url, first I get it's children rendered with previous state (old url, old data, etc.) It looks like the problem is known: https://github.com/jamesplease/react-request/blob/eca89d5fe79bd546a0641b6443415b722e3f6ec3/src/fetch.js#L107 It feels that it would be simple to fix it by updating Fetch state in componentWillReceiveProps hook. @jamesplease what's your opinion?

Contributor guide

Research direction
Implement `componentWillReceiveProps` in the `Fetch` component to update internal state when the `url` prop changes, preventing a render with outdated state.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75