jamesplease/react-request

change `fetching` to be set to `true` on mount for non-lazy requests

Open

#178 opened on May 25, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (21 forks)github user discovery
breakingenhancementhelp wanted

Repository metrics

Stars
 (358 stars)
PR merge metrics
 (PR metrics pending)

Description

I was wondering if you'd consider a slight change for non-lazy behavior. Right now it seems like you need to do:

<Fetch url="/me">
  {({ fetching, failed, data }) => {
    if (fetching) return ...
    if (failed) return ...
    if (!data) return null
    return ...
  }}
</Fetch>

There's an extra case where the component has just mounted, but hasn't yet started the request where fetching == false but data == null. Apollo seems to avoid this, such that you can handle the fetching and failed cases up front, and then assume you have data after that, which just reduces a little of the boilerplate.

Would you be down for that change?

Contributor guide

Research direction
Locate the Fetch component implementation and modify the initial state to set fetching to true on mount when lazy is false.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75