jamesplease/react-request

UglifyJS fails to minify library files

Open

#174 opened on Apr 25, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (21 forks)github user discovery
buildhelp wanted

Repository metrics

Stars
 (358 stars)
PR merge metrics
 (PR metrics pending)

Description

I enjoy using react-request in my project, thanks for creating it!

I decided to try the new version 3 today, but UglifyJS fails to minify it because of the let keywords in the CommonJS version of the library.

I think it happens because the babel-env plugin configuration is missing the targets section and newer language features are not transpiled.

I am going to amend my configuration to transpile the new react-request version, but it would be nice to have it transpiled out of the box. Moreover, the majority of bundler configuration docs and tutorials assume the code in node_modules is already transpiled to ES5.

uglifyjs-error uglifyjs-error-2

Contributor guide

Research direction
Inspect the Babel configuration in package.json or .babelrc and ensure the 'targets' field is set to transpile to ES5, e.g., using 'browserslist' with 'last 1 version' or 'ie 11'. Also check if the library's CommonJS output is being processed by babel correctly.
Tech stack
javascriptreact
Domain
frontendbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65