jamesplease/backbone.premium-router

Test the promise being rejected due to an error

Open

#19 opened on Feb 26, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2 forks)github user discovery
help wantedtests

Repository metrics

Stars
 (7 stars)
PR merge metrics
 (PR metrics pending)

Description

These are (roughly) the tests.

I was unable to do this because mocha flips out when the fetch method throws an error. If anyone knows a way to test this code path – let me know!

Contributor guide

Research direction
To test the promise rejection, wrap the fetch call in a try/catch or use the promise's .catch() method. In Mocha, you can use 'it('should reject', function() { return expect(promise).to.be.rejected; })' with chai as promised. Alternatively, use async/await with try/catch.
Tech stack
javascript
Domain
frontend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptMocha
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65