Add client support for replication scale plans (GET/POST /v1/replication/scale)

オープン
#2,259 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
python
領域
api, backend

調査の方向性

Read the existing client.cluster.replications methods (get, query and cancel), related models in weaviate.cluster.models, and the client’s version checks and stub generation workflow. Implement sync and async methods for retrieving and applying scale plans, with typed models, validation, and server version handling. Add unit, mock, and integration coverage; done means the scale plan can be retrieved and applied against a supported server, with the requested error and validation cases covered.

索引モデルが issue の本文から書いたものです。

説明

Summary

Weaviate has offered GET and POST /v1/replication/scale since v1.35. They compute and apply a plan to change a collection's replication factor. The Python client has no methods for them, so changing a collection's replication factor from Python means making raw REST calls and building the plan payload by hand.

Proposal

Add two methods to the existing client.cluster.replications namespace, next to get, query and cancel, for both the sync and async clients:

plan = client.cluster.replications.get_scale_plan(collection="Article", replication_factor=3)
# inspect plan.shard_scale_actions -> {shard: ShardScaleActions(remove_nodes=[...], add_nodes={target: source | None})}
result = client.cluster.replications.apply_scale_plan(plan=plan)
# result.operation_ids -> the started shard copy operations, trackable with replications.get(uuid=...)
  • New typed models in weaviate.cluster.models: ReplicationScalePlan, ShardScaleActions and ReplicationScaleApplyResult. They are exported from weaviate.outputs.replication.
  • A version check raises WeaviateUnsupportedFeatureError on servers older than 1.35, the same way tokenization and export do.
  • replication_factor is validated on the client (it must be an integer of at least 1), and the collection name's first letter is capitalised, as elsewhere in the client.
  • Additive only: no changes to existing signatures, overloads or dependencies. The stubs are regenerated with tools/stubs_regen.sh.
Validation done locally

I have a working implementation, tested against a local 3-node 1.40.5 cluster with REPLICA_MOVEMENT_ENABLED=true:

  • Scaling a 2-shard collection from 1 to 3 replicas started 4 copy operations, all of which reached READY, and all objects stayed readable.
  • Scaling back down produced a removal-only plan, applied with no copy operations.
  • Added unit and mock tests (sync and async, plan round-trip, invalid factor, old-server error) and an integration test in integration/test_replicate.py.
  • ruff, pyright 1.1.399 and the flake8 pre-commit hooks pass.

Would you accept a PR for this? I'm happy to adjust the method names or where they live, for example on client.cluster next to replicate() instead.

主要言語
Python
スター
230
フォーク
173
平均マージ
4日 16時間
マージ済み PR(30日)
23

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

weaviate/weaviate-python-client のほかの issue

weaviate/weaviate-python-client の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。