`VoidActionError.message` ignores the server's message, though the docs show it to users

オープン
  • 何か問題がありますか？
#680 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@karthickeyan-dev がすでに取り組んでいます。

2026年11月3日 から。

  • #691 @karthickeyan-dev による — オープン

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
52/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
react, typescript
領域
documentation, frontend

調査の方向性

Start in pages/action-result.ts, where the VoidActionError constructor builds message and currently reads body only for a 429 usage limit. Then read the action() section of docs/guide/pages-routing/actions-and-forms.md, which shows result.error.message in a toast. Done when a 4xx with a text body sets message to that body, 5xx and empty bodies keep the status line, and the docs describe message accurately. The optional isVoidActionError() export is a separate decision to confirm with maintainers.

索引モデルが issue の本文から書いたものです。

説明

Summary

When an action fails, VoidActionError.message is a status line such as Action failed with 404 Not Found. A 429's usage-limit message is the only exception. The handler's own message, for example from HTTPException, ends up only in error.body.

The action() guide shows the message to users:

if (!result.ok) {
  showToast(result.error.message);
}

Followed as written, that toast says "Action failed with 404 Not Found" instead of what the action said.

Reproduction
// pages/notes.server.ts
import { HTTPException } from 'hono/http-exception';
import { defineHandler } from 'void';

export const action = defineHandler(async (c) => {
  const status = Number(c.req.query('status'));
  throw new HTTPException(status as 404, { message: 'That note was deleted.' });
});

// pages/notes.tsx
const result = await action(`/notes?status=${status}`, { data: {} });
// For 403 and 500, action() throws, so read the caught error instead.

The server answers with the message as text/plain. On the client:

Status action() error.message error.body isCallSiteActionError()
404 returns Action failed with 404 Not Found That note was deleted. true
409 returns Action failed with 409 Conflict That note was deleted. true
422 returns Action failed with 422 Unprocessable Entity That note was deleted. true
403 throws Action failed with 403 Forbidden That note was deleted. false
500 throws Action failed with 500 Internal Server Error That note was deleted. false

The message is built in VoidActionError's constructor (pages/action-result.ts), which reads body only for a 429's usage limit.

Why it matters
  • The documented pattern shows a status line. An app that follows the guide shows users text written for developers.
  • Every app writes the same helper. To show the action's message, each app checks that body is a non-empty string and falls back otherwise, and has to know that Void stores a text body there.
  • Thrown errors have no guard. 401, 403 and 5xx reach the error boundary, where the only exported guard, isCallSiteActionError(), is false for them. Apps check error.name === 'VoidActionError' by hand, as the guard itself does, because instanceof isn't reliable when the class is bundled more than once.
Proposal
  1. Use the server's text for 4xx. When the status is 4xx and body is a non-empty string, set message to it, as the constructor already does for a 429's limit message. Keep the status line for 5xx, where the text may not be meant for users, and when there's no body. status and statusText still carry the status.
  2. Export isVoidActionError(), true for every status, so error boundaries can recognise action errors.
  3. At minimum, fix the docs. Say what message holds, and change the action() example to read error.body with a fallback.
Prior art
  • Better Auth, which Void bundles: a failed call's error.message is the server's message.
  • SvelteKit: error(404, 'That note was deleted.') reaches the page as page.error.message.
Workaround
// By name: instanceof fails across bundled copies.
function isActionError(error: unknown): error is VoidActionError {
  return error instanceof Error && error.name === 'VoidActionError';
}

function getErrorMessage(error: unknown): string {
  if (isActionError(error) && error.status < 500 && typeof error.body === 'string' && error.body) {
    return error.body;
  }
  return 'Something went wrong, please try again';
}
Environment
  • void 1.5.0
  • @void/react 1.5.0
主要言語
TypeScript
スター
627
フォーク
66
平均マージ
14時間 38分
マージ済み PR（30日）
179

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

voidzero-dev/void のほかの issue

voidzero-dev/void の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。