`vp run`: an option to keep going after a task fails (today one failure kills unrelated running tasks and their results are lost)
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 35/100
調査の方向性
Start in crates/vt/src/session/execute/scheduler.rs, where a failure cancels the shared token (around lines 229-231), and in cache_update.rs, where cancelled runs are skipped for caching (around lines 48-49). A --continue flag would need to stop that cancellation, skip only tasks that depend on a failure, and set a non-zero exit code at the end. Done means a fixture with independent failing and passing packages finishes the passing ones, caches them, and exits non-zero. The issue is a feature with a design choice (which continue modes to support), so confirm the scope with maintainers before starting.
索引モデルが issue の本文から書いたものです。
説明
Summary
When a task fails, vp run cancels the whole run. Tasks that are running and do not depend on the failed task are killed, tasks not yet started never run, and none of them gets a cache entry. There is no option to change this.
This asks for one: keep running every task whose dependencies succeeded, skip only the tasks that depend on a failure, and exit non-zero at the end.
What happens today
A workspace of four packages with no dependencies between them. a fails after 2 s; b, c and d take 8 s.
// packages/a/package.json
{ "name": "a", "scripts": { "check": "node -e \"setTimeout(() => process.exit(1), 2000)\"" } }
// packages/b/package.json (c and d are the same)
{ "name": "b", "scripts": { "check": "node -e \"setTimeout(() => console.log(1), 8000)\"" } }
$ vp run --cache -r check
vp run: 0/4 cache hit (0%), 4 failed.
$ vp run --last-details
[1] a#check ... ✗ (exit code: 1)
[2] c#check ... ✗ (exit code: 137)
[3] d#check ... ✗ (exit code: 137)
[4] b#check ... ✗ (exit code: 137)
The run ends after about 2 s. b, c and d were healthy and independent of a. They are reported as failed, and the next run starts them from nothing. (vp v1.0.0, macOS.)
In the source this is unconditional. The scheduler cancels the shared token on any failure (scheduler.rs#L229-L231), and a run cancelled that way is not cached (cache_update.rs#L48-L49).
Why it matters
- One failure per run. In a recursive
testorlintover many packages, the first failure hides every other one. A change that breaks three packages takes three runs to fix, and in CI each run is a round trip. - A flake costs the whole run. One test that times out kills every suite still running. Their results are lost, so the retry re-executes work that was about to pass.
- The killed tasks read as failures. They show
exit code: 137beside the real failure and the summary counts them as failed, so the reader has to work out which one was the cause. - The workaround is expensive. To get a result per package, a CI job has to start one
vp run <package>#<task>process per package. Those processes then replay the same dependency tasks at the same time, and a cache hit restores a task's outputs over the existing files while another process is reading them. So the job also has to run the shared dependencies once up front and pass--ignore-depends-onto every process.
Prior art
| Tool | Option | Its documentation |
|---|---|---|
| GNU Make | -k, --keep-going |
"Keep going when some targets can't be made." |
| Turborepo | turbo run --continue[=never|dependencies-successful|always] |
Default never. With dependencies-successful: "turbo will cancel dependent tasks. Tasks whose dependencies have succeeded will continue to run." |
| pnpm | pnpm run --no-bail |
"Continue running the remaining matched scripts even if one of them fails. The command still exits with a non-zero exit code if any script failed." |
| Nx | --nxBail |
"Stop command execution after the first failed task." |
| Cargo | cargo test --no-fail-fast, cargo build --keep-going |
"Run all tests regardless of failure"; "Do not abort the build as soon as there is an error" |
Proposal
vp run --continue [TASK_SPECIFIER]
- A task that fails does not cancel the run.
- A task whose dependencies all succeeded still runs, and its result is cached as in any other run.
- A task that depends on a failed task, directly or through others, does not run. It is reported as skipped, naming the failure it waited on. This is Turborepo's
dependencies-successful. - The run exits non-zero if any task failed, after every runnable task has finished.
- Ctrl-C still cancels everything.
With the example above it would print:
$ vp run --cache --continue -r check
vp run: 0/4 cache hit (0%), 1 failed.
$ vp run --cache --continue -r check
vp run: 3/4 cache hit (75%), 1 failed.
A config key for the default would let a workspace choose it for CI. The flag alone is enough to start.
Non-goals
- Changing the default.
- Running the dependents of a failed task (Turborepo's
always). - Retrying a failed task.
How we hit it
A monorepo of about 80 packages that runs vp run -r test in CI. One test timed out by 10 ms, and three healthy suites that were still running were killed with exit 137. None of the three stored a result, so the retry ran all four again, one of them with 1,282 tests. We now run one process per package to keep each verdict, at the cost described above.
- 主要言語
- Rust
- スター
- 473
- フォーク
- 44
- 平均マージ
- 1日 19分
- マージ済み PR(30日)
- 55
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
voidzero-dev/vite-task のほかの issue
-
Let tools mark cache directories with CACHEDIR.TAG対応中かも @lifeiscontent が 7 日前に担当しました。 オープン
難易度 4/5 3〜5日 初心者へのやさしさ 35/100
voidzero-dev/vite-task#793 ·
メンテナーはふだん 1 日以内に返信
-
Preview cache hits without running tasks対応中かも @lifeiscontent が 8 日前に担当しました。 オープン
難易度 4/5 3〜5日 初心者へのやさしさ 52/100
voidzero-dev/vite-task#791 ·
メンテナーはふだん 1 日以内に返信
-
Built-in tool tasks miss the cache after the workspace moves対応中かも @lifeiscontent が 8 日前に担当しました。 オープン
難易度 3/5 1〜2日 初心者へのやさしさ 67/100
voidzero-dev/vite-task#790 ·
メンテナーはふだん 1 日以内に返信
-
vp run: output forwarding fails with EAGAIN when an inherited Node child sets stdout non-blocking対応中かも @naokihaba が 5 日前に担当しました。 オープン
難易度 4/5 3〜5日 初心者へのやさしさ 48/100
voidzero-dev/vite-task#782 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
remote cache
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
voidzero-dev/vite-task#781 ·
メンテナーはふだん 1 日以内に返信
voidzero-dev/vite-task の issue をすべて見る
似ている issue
-
bug user-priority/P2
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
rescript-lang/rescript#8765 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
nautechsystems/nautilus_trader#5287 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 62/100
farion1231/cc-switch#8072 ·
メンテナーはふだん 1 日以内に返信
-
Python 3.15 support対応中かも @amnesiaof が今日担当しました。 オープンL: python L: python:uv
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
dependabot/dependabot-core#16524 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信