Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

vm.stop force-kills the guest after 10 seconds; vm.reboot can leave a slow guest off

オープン
#2,114 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
66/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
graphql, typescript
領域
api, backend

調査の方向性

Start in api/src/unraid-api/graph/resolvers/vms/vms.service.ts, especially VmsService.setVmState, waitForDomainShutdown, and rebootVm; trace how the stop and reboot mutations handle libvirt shutdown requests and timeouts. The issue reports a 10-second polling limit followed by domain.destroy() for stop and an error for reboot. Done means slow guest shutdowns are not unexpectedly force-killed or left off after a failed reboot, while forceStop remains the hard-stop path.

索引モデルが issue の本文から書いたものです。

説明

Environment

Unraid OS Version: 7.4.0-rc.1 (API 4.37.5); the code is unchanged on main as of 2026-10-17.

Are you using a reverse proxy? No. Tested against the server directly.

Pre-submission Checklist

  • I have verified that my Unraid OS is up to date
  • I have tested this issue by accessing my server directly (not through a reverse proxy)
  • This is not an Unraid Connect related issue (if it is, please submit via the support form instead)

Issue Description

vm.stop is the graceful stop (vm.forceStop is the hard one), but it doesn't stay graceful. In VmsService.setVmState (api/src/unraid-api/graph/resolvers/vms/vms.service.ts), stopping calls domain.shutdown() and then waitForDomainShutdown(), which polls 10 times at 1 second (maxRetries = 10). If the guest is not off by then, it calls domain.destroy(). Any guest that takes more than 10 seconds to shut down is powered off: Windows installing updates, Home Assistant OS, a database VM flushing to disk. The client is told the stop succeeded.

vm.reboot (rebootVm) sends the same domain.shutdown() and waits the same 10 seconds. If the guest is not off by then, it throws "Graceful shutdown failed, please force stop the VM and try again". The guest has already received the shutdown request, though, so a slow guest goes on shutting down and ends up off, not rebooted, while the client was told the reboot failed.

Steps to Reproduce

  1. Create a VM with no OS (nothing answers the ACPI shutdown).
  2. Start it, then call mutation { vm { stop(id: "<id>") } }.
  3. Start it again, then call mutation { vm { reboot(id: "<id>") } }.

Expected Behavior

  • stop should not destroy the domain. libvirt's shutdown() doesn't time out on its own, so stop could return once the request is sent, or wait longer and then return an error or a "still shutting down" result. Leave the hard stop to forceStop. A configurable or much longer timeout would also work.
  • reboot could use domain.reboot() (libvirt's guest reboot), or keep waiting until the guest is off before starting it again.

Actual Behavior

  • Step 2: stop returned true after about 10.3 s, and the domain was SHUTOFF (destroyed).
  • Step 3: reboot failed after about 10 s with the message above. The VM stayed running only because nothing inside it reacted; a real guest would have gone on shutting down.

Additional Context

Mobile and remote clients present stop as the safe option next to "force stop", and users pick it precisely to avoid data loss. Our Android client now warns users about the 10-second power cut.

主要言語
TypeScript
スター
115
フォーク
23
平均マージ
4日 1時間
マージ済み PR(30日)
7

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

unraid/api のほかの issue

unraid/api の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。