Backport workflow-hardening fix (unpinned-uses) to 3 release branches

オープン
#7,137 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@emirhan-karaca がすでに取り組んでいます。

2026年9月14日 から。

  • #7155 @emirhan-karaca による — オープン
  • #7156 @emirhan-karaca による — オープン
  • #7157 @emirhan-karaca による — オープン

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
68/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
github-actions
領域
ci-cd, security

調査の方向性

.github/workflows/ci.yml を release ブランチ 2.21、2.20、2.19 で確認し、各ブランチを commit 1501f462ad61eba0a8b93910d3995e50fbaab784 にある default ブランチの修正と比較します。各ブランチに対して、一覧にある action の pinning 変更を適用し、その後 zizmor と actionlint を実行します。unpinned-uses の findings が解消され、新しい lint または security の findings が発生しなければ完了です。

索引モデルが issue の本文から書いたものです。

説明

Summary

The default branch already hardened .github/workflows/ci.yml against the issue(s) below, but 3 release branches still carry it. This proposes the same, minimal, scanner-verified fix for each.

What's flagged (by zizmor)
  • unpinned-uses — actions referenced by mutable tag/branch instead of a pinned commit SHA

Already resolved on the default branch in:

Affected release branches (3)
  • 2.21 (still present as of HEAD 6feb9c90)
  • 2.20 (still present as of HEAD 474d3eef)
  • 2.19 (still present as of HEAD 3fceda6d)
Suggested per-branch patches

Each diff below was checked locally with zizmor and actionlint: the flagged finding(s) are cleared on the affected construct and no new lint or security findings are introduced. (Whitespace is normalized; only security-relevant lines change.)

2.21 — unpinned-uses

File .github/workflows/ci.yml; suggested edits:

  • ~ jobs.$J2.steps[uses=actions-rs/toolchain].uses : pin(actions-rs/toolchain -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/cache].uses : pin(actions/cache -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/upload-artifact].uses : pin(actions/upload-artifact -> target_ref SHA)
  • ~ jobs.$J.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J3.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J3.steps[uses=actions/setup-node].uses : pin(actions/setup-node -> target_ref SHA)
  • ~ jobs.$J4.steps[uses=DoozyX/clang-format-lint-action].uses : pin(DoozyX/clang-format-lint-action -> target_ref SHA)
  • ~ jobs.$J4.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J5.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J5.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J6.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J6.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions-rs/clippy-check].uses : pin(actions-rs/clippy-check -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions-rs/toolchain].uses : pin(actions-rs/toolchain -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions/cache].uses : pin(actions/cache -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -188,7 +188,7 @@
           architecture: 'x64'
       - name: 'Cache Cargo artifacts'
         if: matrix.mode == 'native'
-        uses: actions/cache@v4
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830  # v4
         with:
           path: |
             tensorboard/data/server/target/
@@ -239,7 +239,7 @@
             --out-dir /tmp/pip_package \
             ;
       - name: 'Upload'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02  # v4
         with:
           name: tensorboard-data-server_${{ matrix.mode }}_${{ matrix.platform }}_${{ matrix.rust_version }}
           path: /tmp/pip_package/*
@@ -307,7 +307,7 @@
     steps:
       - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
       - name: 'Cache Cargo artifacts'
-        uses: actions/cache@v4
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830  # v4
         with:
           path: |
             tensorboard/data/server/target/
2.20 — unpinned-uses

File .github/workflows/ci.yml; suggested edits:

  • ~ jobs.$J2.steps[uses=actions-rs/toolchain].uses : pin(actions-rs/toolchain -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/cache].uses : pin(actions/cache -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/upload-artifact].uses : pin(actions/upload-artifact -> target_ref SHA)
  • ~ jobs.$J.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J3.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J3.steps[uses=actions/setup-node].uses : pin(actions/setup-node -> target_ref SHA)
  • ~ jobs.$J4.steps[uses=DoozyX/clang-format-lint-action].uses : pin(DoozyX/clang-format-lint-action -> target_ref SHA)
  • ~ jobs.$J4.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J5.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J5.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J6.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J6.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions-rs/clippy-check].uses : pin(actions-rs/clippy-check -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions-rs/toolchain].uses : pin(actions-rs/toolchain -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions/cache].uses : pin(actions/cache -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -160,7 +160,7 @@
           architecture: 'x64'
       - name: 'Cache Cargo artifacts'
         if: matrix.mode == 'native'
-        uses: actions/cache@v4
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830  # v4
         with:
           path: |
             tensorboard/data/server/target/
@@ -211,7 +211,7 @@
             --out-dir /tmp/pip_package \
             ;
       - name: 'Upload'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02  # v4
         with:
           name: tensorboard-data-server_${{ matrix.mode }}_${{ matrix.platform }}_${{ matrix.rust_version }}
           path: /tmp/pip_package/*
@@ -279,7 +279,7 @@
     steps:
       - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
       - name: 'Cache Cargo artifacts'
-        uses: actions/cache@v4
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830  # v4
         with:
           path: |
             tensorboard/data/server/target/
2.19 — unpinned-uses

File .github/workflows/ci.yml; suggested edits:

  • ~ jobs.$J2.steps[uses=actions-rs/toolchain].uses : pin(actions-rs/toolchain -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/cache].uses : pin(actions/cache -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/upload-artifact].uses : pin(actions/upload-artifact -> target_ref SHA)
  • ~ jobs.$J.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J3.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J3.steps[uses=actions/setup-node].uses : pin(actions/setup-node -> target_ref SHA)
  • ~ jobs.$J4.steps[uses=DoozyX/clang-format-lint-action].uses : pin(DoozyX/clang-format-lint-action -> target_ref SHA)
  • ~ jobs.$J4.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J5.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J5.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J6.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J6.steps[uses=actions/setup-python].uses : pin(actions/setup-python -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions-rs/clippy-check].uses : pin(actions-rs/clippy-check -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions-rs/toolchain].uses : pin(actions-rs/toolchain -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions/cache].uses : pin(actions/cache -> target_ref SHA)
  • ~ jobs.$J7.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -211,7 +211,7 @@
             --out-dir /tmp/pip_package \
             ;
       - name: 'Upload'
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02  # v4
         with:
           name: tensorboard-data-server_${{ matrix.mode }}_${{ matrix.platform }}_${{ matrix.rust_version }}
           path: /tmp/pip_package/*

Happy to open pull requests instead if that's preferred.

主要言語
TypeScript
スター
7.2k
フォーク
1.7k
平均マージ
1日 13時間
マージ済み PR(30日)
3

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

tensorflow/tensorboard のほかの issue

tensorflow/tensorboard の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。