A failed GitHub sign-in shows only a JSON error

オープン
#644 コメント 2 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@Ray891220 がすでに取り組んでいます。

2026年11月10日 から。

評価

この issue はまだ評価されていません。

説明

A failed GitHub sign-in leaves the user on a page that shows only a JSON object, such as {"error":"Login state is missing or expired."}. There is no explanation of what went wrong and no link back to where the sign-in started, so the only way on is to edit the address bar.

Who is affected: anyone signing in with GitHub, which reciprocal practice requires, and the operator they ask for help.

Where it comes from: callback_response in src/web/auth.rs (at 5e00eab) returns json_response for every failure of a browser navigation, not an API call. Reachable cases include:

  • Missing GitHub callback code.: GitHub sends the user back with ?error=access_denied and no code when they press Cancel on the authorization page.
  • Missing GitHub callback state.
  • Login state is missing or expired.: the state cookie is absent, for example after a slow authorization or when the callback lands on a different origin than the one that started the sign-in.
  • Login state did not match.

Desired outcome: a failed sign-in shows a readable page that names the likely cause in a sentence and offers a link that starts sign-in again, returning to the page the user came from (/peer-lobby when the sign-in began there).

Acceptance criteria:

  • Pressing Cancel on GitHub's authorization page lands on a page that says the sign-in was cancelled and offers to try again.
  • An expired or missing state shows a page that suggests signing in again from the same address, with a working link.
  • API clients that call these routes, if any, still get a status code they can test; the change concerns what a browser renders.

Current workaround: open /peer-lobby again by hand and press Sign in with GitHub.

主要言語
Rust
スター
228
フォーク
150
平均マージ
1日 3時間
マージ済み PR(30日)
230

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

sysprog21/codetrial のほかの issue

sysprog21/codetrial の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。