Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

`createRoot`'s dispose function keeps `fn` alive, so `<For>`/`<Index>` rows retain removed list items

オープン
  • 何か問題がありますか？
#4,095 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@boombang がすでに取り組んでいます。

2026年10月15日 から。

  • #4096 @boombang による — オープン

評価

難易度
4/5
見積もり時間
1〜2日
初心者へのやさしさ
45/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
javascript, typescript
領域
frontend, performance

調査の方向性

Start with createRoot and the updateFn line that builds the dispose closure, then trace how mapArray and indexArray store each row's disposer in disposers. Run the repro script with node --expose-gc --conditions=browser repro.mjs. Done means both lines print false, and the existing tests for createRoot and the array helpers still pass.

索引モデルが issue の本文から書いたものです。

説明

1.x
Describe the bug

createRoot creates the dispose function it passes to fn inside its own scope:

updateFn = unowned ? ... : () => fn(() => untrack(() => cleanNode(root)));

That scope also holds fn, because updateFn closes over it. So anything that keeps the dispose function also keeps fn, and everything fn closes over.

mapArray and indexArray keep every row's dispose function in disposers. Every row's fn is mapper, and mapper closes over newItems, the list that was current when the row was created. So a mounted row keeps that whole list reachable, including items that were removed from the list later.

We found this in production. A long-lived <For> row kept a list it was created from, and with it a replaced document of a few hundred MB.

Your Example Website or App

Standalone script below (Node 22, solid-js 1.9.17, client build).

Steps to Reproduce the Bug or Issue
// npm i [email protected]
// node --expose-gc --conditions=browser repro.mjs
import { createRoot, createSignal, createMemo, mapArray, indexArray } from "solid-js";

const collect = async () => {
  // WeakRef targets stay alive until the current job ends.
  await new Promise(r => setTimeout(r, 0));
  globalThis.gc();
};

// A row created from [kept, removed] stays mounted after the list becomes [kept].
async function check(name, map) {
  const kept = { name: "kept" };
  let removed, setList;
  const dispose = createRoot(dispose => {
    const [list, set] = createSignal(
      (() => {
        const item = { name: "removed" };
        removed = new WeakRef(item);
        return [kept, item];
      })()
    );
    setList = set;
    createMemo(map(list))();
    return dispose;
  });
  setList([kept]);
  await collect();
  console.log(`${name}: removed item still reachable:`, removed.deref() !== undefined);
  dispose();
}

await check("mapArray (<For>)", list => mapArray(list, item => item.name));
await check("indexArray (<Index>)", list => indexArray(list, item => item().name));

Output:

mapArray (<For>): removed item still reachable: true
indexArray (<Index>): removed item still reachable: true

The dev build (dist/dev.js) gives the same output, and so does Bun (JavaScriptCore) with Bun.gc(true).

Expected behavior

Once the row for removed is disposed, nothing should keep removed reachable, so both lines should print false. They do once the dispose function is created outside createRoot's scope, in both V8 and JavaScriptCore.

Platform
  • solid-js: 1.9.17 (main)
  • Node 22.23 (V8), Bun 1.4.2 (JavaScriptCore)
Additional context

I haven't checked next (2.0) yet. The fix for 1.x is in the PR linked below.

主要言語
TypeScript
スター
36.2k
フォーク
1.1k
平均マージ
10時間 34分
マージ済み PR（30日）
364

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

solidjs/solid のほかの issue

solidjs/solid の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。