A live hole silently stops re-emitting when its markup has a conditional on a property (`{m.usage && …}`)
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 15/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- javascript, typescript
調査の方向性
Start with the repro in the issue: a live GET server component whose markup holds a createMemo over an async source, with a {m.usage && <b>done</b>} conditional inside a .map() row. Compare the streamed hole events with and without the conditional, as the issue's table does. The likely area is how the compiler memoises conditionals whose condition is a property access, and how a memo created inside a re-running hole is tracked. The existing chat example's comment about owner creation is a lead. Done means the hole re-emits, or a dev diagnostic names the expression.
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
In a live server component, a markup hole stops re-emitting, silently, when the expression it renders contains a conditional whose condition is a property access. The first render is correct. After that the hole is never sent again, however often its source yields. There is no error, no warning and no diagnostic, on the server or in the browser. Slot arguments in the same component keep updating, which makes it look like a client problem.
What it takes
A live(GET(…)) server function that answers with a component, with a memo over an async iterable read in its markup:
const getThread = liveQuery(
live(
GET(async (id: string) => {
"use server";
return (props: { composer: ComposerSlot }) => {
const view = createMemo(() => db.watchThread(id, signal)); // yields the thread on every write
return (
<article>
<ol>
{view().messages.map(m => (
<li data-id={m.id}>
{m.text.length} {m.usage && <b>done</b>}
</li>
))}
</ol>
<props.composer seen={view().messages.map(m => m.id)} />
</article>
);
};
})
),
"thread"
);
m.usage is undefined until a reply finishes; m.text grows about every 50 ms while one is being written.
What happens
I connected to the live address with curl -N for the length of one reply (about 40 writes to the thread) and counted the events on the stream, changing only the expression inside the <li>:
Inside the <li> |
hole events for the list |
slot-argument events |
|---|---|---|
{m.text.length} |
39 | 43 |
{m.text.length} {m.usage && <b>done</b>} |
0 | 43 |
{m.text.length} {m.usage ? <b>done</b> : null} |
0 | 43 |
const usage = m.usage; then {m.text.length} {usage && <b>done</b>} |
39 | 43 |
In the two failing rows the stream carries the initial html event, with the list registered as a hole and given a digest, and then nothing more for it. In the browser the list stays as first rendered while the composer's seen prop keeps changing.
The same happens when the conditional is inside a plain helper function called from the hole, and with <For> in place of .map(). A condition that is a local identifier (generating && …, where const generating = m.status === "generating") is fine.
What I think is going on
Not established; a reading of the symptoms. The compiler memoises a conditional whose condition it cannot see through (a.b && …, a.b ? … : …). The existing chat example's comments say a live hole "can't mint components as it grows" (an owner-creation latch). A memo created inside a hole on each re-run looks like the same thing, with the difference that nothing reports it and the hole goes quiet instead.
Expected
Either the hole re-emits, or, if creating a memo inside a re-running hole is not supported, a dev diagnostic says so and names the expression. As it stands the markup is silently stale, and the workaround (hoist the property into a local) is not something a reader would guess.
Notes
- Found while rebuilding the chat example as a live server component. It first appeared as
{message.reasoning && <details>…}and{message.usage && <span>…}in a message's markup, and took a bisect of the raw stream to find. - Related, and loud rather than silent: a memo over an async source created per row inside the list (
createMemo(() => db.watchMessage(id))in a row component) fails the document render with<Loading> boundary discovery did not converge after 10001 passes. That one at least says something.
Environment
solidjs/solidnextatdf4e36516, dev build ofsolid-jsand@solidjs/webfrom the workspace@solidjs/router2.0.0-next.38,@solidjs/vite-plugin3.0.0-next.49, Vite 8, dev server- macOS, Node 26; the stream was read with curl, the page in Chromium 152
- 主要言語
- TypeScript
- スター
- 36.1k
- フォーク
- 1.1k
- 平均マージ
- 10時間 42分
- マージ済み PR(30日)
- 361
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
solidjs/solid のほかの issue
-
難易度 4/5 3〜5日 初心者へのやさしさ 20/100
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 15/100
メンテナーはふだん 1 日以内に返信
-
bug
難易度 4/5 3〜5日 初心者へのやさしさ 15/100
メンテナーはふだん 1 日以内に返信
-
bug
難易度 4/5 3〜5日 初心者へのやさしさ 25/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 8/100
メンテナーはふだん 1 日以内に返信
似ている issue
-
enhancement good first issue help wanted
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
OWASP/cve-lite-cli#1335 ·
メンテナーはふだん 1 日以内に返信
-
Windows: main-screen mouse tracking requires WT_SESSION, so it never enables inside herdr panesオープン
難易度 1/5 1時間未満 初心者へのやさしさ 66/100
code-yeongyu/senpi#3353 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
Channels status: needs triage
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
mastra-ai/mastra#27093 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
enhancement needs-triage ui
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
メンテナーはふだん 1 日以内に返信