Client navigation to a server route without a `search` schema throws: args carry `search: undefined`, which JSON arguments reject
まだ誰も着手していません。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 65/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- javascript, nodejs, typescript
調査の方向性
Look at src/serverRouteShared.ts to see how serverRouteArgs always returns search: undefined. Understand the isJSONSafe check in @solidjs/web that rejects undefined. The fix likely involves modifying the router to omit the search key when no schema exists, or adjusting the serialization logic. Test by reproducing the bug with the provided example and verifying client navigation works after changes.
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
serverRouteArgs (src/serverRouteShared.ts) always returns { params, search }, and search is undefined when the route declares no search schema. On the client, @solidjs/web sends server function arguments as plain JSON by default. Its isJSONSafe check rejects undefined anywhere in the arguments, so the call throws before any request is made:
Server function arguments are sent as JSON by default and these arguments are not JSON-serializable. Call enableRichArguments() (from "@solidjs/web/server-functions/rich-args") once at startup ...
The route shows the error boundary instead of the page. Server rendering is not affected, because the server calls the function directly, so the first page load works and only client navigation fails. This covers every serverRouteComponent route and every file-system server page that has no search schema, which is the common case.
Your Example Website or App
The code below. I ran it as-is in a Vite start-mode app whose src/app.tsx renders <Router> inside <Loading>.
Steps to Reproduce the Bug or Issue
With @solidjs/router@2.0.0-next.28, @solidjs/web@2.0.0-rc.9 and @solidjs/vite-plugin@3.0.0-next.44 (start: {}, ssr: true, serverFunctions: { components: true }):
import { createRouter, defineRoute, query, serverRouteComponent } from "@solidjs/router";
const home = async () => {
"use server";
return () => <a href="/about">About</a>;
};
const about = async () => {
"use server";
return () => <p>About</p>;
};
export const Router = createRouter({
routes: [
defineRoute({ path: "/", component: serverRouteComponent(query(home, "home")) }),
defineRoute({ path: "/about", component: serverRouteComponent(query(about, "about")) })
]
});
- Load
/. It renders. - Click the "About" link.
- The client throws the error above, and no
/_server/data/...request is sent.
Calling enableRichArguments() at startup makes the navigation work, which confirms search: undefined is the only non-JSON value in the arguments.
Expected behavior
Navigating to a server route without a search schema should work with the default JSON argument encoding. The router could leave the search key out when there is no schema. A missing key and an explicit undefined look the same to the server function's destructuring, and the query key only needs the args to be stable. Alternatively, @solidjs/web's isJSONSafe could skip undefined object properties the way JSON.stringify does. The router seems like the smaller fix, since apps shouldn't need rich arguments just to use server routes.
Screenshots or Videos
None.
Platform
- OS: macOS 15 (Darwin 24.3.0)
- Browser: Chromium 149 (headless, Playwright)
- Versions:
@solidjs/router@2.0.0-next.28,@solidjs/web@2.0.0-rc.9,solid-js@2.0.0-rc.9,@solidjs/vite-plugin@3.0.0-next.44
Additional context
Using enableRichArguments() as a workaround currently runs into a separate @solidjs/web packaging bug in Vite builds (the rich-args import does not resolve under rolldown), so apps need a resolve alias as well.
- 主要言語
- TypeScript
- スター
- 1.3k
- フォーク
- 180
- 平均マージ
- 1日 10時間
- マージ済み PR(30日)
- 19
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
solidjs/solid-router のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
solidjs/solid-router#605 · コメント 1 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 78/100
solidjs/solid-router#603 · コメント 1 件 ·
-
<A> costs ~6us of server CPU per instance during SSR (20x a plain <a>), mostly mergeProps/splitProps オープン
難易度 4/5 3〜5日 初心者へのやさしさ 55/100
solidjs/solid-router#583 ·
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
solidjs/solid-router#569 · コメント 3 件 ·
-
enhancement
難易度 3/5 1〜2日 初心者へのやさしさ 38/100
solidjs/solid-router#518 · コメント 2 件 ·
solidjs/solid-router の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
bcgov/bc-wallet-mobile#4761 · コメント 1 件 ·
-
external-issue to-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
-
area-deployment area-integrations triage:bot-seen
難易度 2/5 半日 初心者へのやさしさ 86/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
-
refactor
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100