Use MSVC-supported explicit atomics in TDD occurrence fixtures
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
調査の方向性
Start with tests/test_tdd_occurrence_execution.c and inspect the 16 implicit atomic_load/atomic_store calls, then compare the explicit forms provided by wirelog/columnar/mem_ledger.h. Preserve the existing values, ordering intent, and fixture assertions; run the tdd_occurrence_execution target normally and under ASan/UBSan with leak detection. The issue also requires compatibility checks, independent review, and native MSVC build/link/test success on the submitted head.
索引モデルが issue の本文から書いたものです。
説明
Scope
Use the repository's MSVC-supported explicit atomic APIs for the 16 implicit atomic_load/atomic_store accesses in tests/test_tdd_occurrence_execution.c on the private #1984 implementation stack. Preserve budget values, ordering intent, source/descriptor-reader checks, fixture sequencing, refusal/fault/retry assertions and all generated CSPA body tests. Keep the repair separate from PR #2010's consolidation fixture and from production atomic-shim changes.
Discovery context
The native PR #2010 Windows/MSVC job failed with C4013/LNK2001 for implicit atomic_store in a different test. Investigating that observed failure found that wirelog/columnar/mem_ledger.h provides only the explicit load/store forms under _MSC_VER.
Read-only inspection of the private TDD head a0b3bc0626545febd576b2259a83b6a7fb06e9f5 (tree 8596f0d64a8442441ee8ee07eb3bc83464e261d9) found 16 analogous implicit accesses in the occurrence execution fixture: governor limits and source/descriptor access states. Its Linux normal and ASan/UBSan tests pass, but that does not establish native MSVC compatibility. This is a predicted portability gap; no native Windows failure has yet been observed for this private head. Architect and Critic discussed the shared cause and agreed to track this branch-local repair separately under #1984.
Acceptance criteria
- Replace all 16 unsupported convenience calls with supported explicit forms, preserving access values and ordering intent; no weakening or bypass of reader exclusion, governor accounting, error, ownership or retry checks.
- A complete-TU compatibility negative control exposes the original implicit calls, and the corresponding repaired-source check passes. Clearly label host simulations; do not pretend defining
_MSC_VERunder GCC reproduces Windows ABI behavior. - The existing
tdd_occurrence_executiontarget passes normally and under ASan/UBSan with leak detection, including generated valueAlias/valueFlow recursive bodies, both seed families and memoryAlias K1 controls. - Verify the diff is confined to this test and production/build/profile inputs are unchanged before reusing prior size evidence.
- Obtain independent exact-tree review/design/risk approval and an atomic private commit. Reconcile the eventual public stack to actual main and require native MSVC build/link/test success plus all required checks on its submitted head.
Existing #1989 performance/publication prerequisites remain. This does not provide SCC scheduling, coherent publication, signed/retraction correctness, full CSPA dispatch or #1982 replacement qualification, and does not alter other agents' #1963–#1965 work.
- 主要言語
- C
- スター
- 18
- フォーク
- 2
- 平均マージ
- 10時間 9分
- マージ済み PR（30日）
- 173
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
semantic-reasoning/wirelog のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 83/100
semantic-reasoning/wirelog#2229 ·
メンテナーはふだん 1 日以内に返信
-
Doc: insert executor and incremental consolidation leave sorted runs, not globally sorted headsオープン
難易度 1/5 1時間未満 初心者へのやさしさ 83/100
semantic-reasoning/wirelog#2133 ·
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
semantic-reasoning/wirelog#2042 ·
メンテナーはふだん 1 日以内に返信
-
p2-medium
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
semantic-reasoning/wirelog#1914 ·
メンテナーはふだん 1 日以内に返信
-
難易度 3/5 1〜2日 初心者へのやさしさ 58/100
semantic-reasoning/wirelog#2262 ·
メンテナーはふだん 1 日以内に返信
semantic-reasoning/wirelog の issue をすべて見る
似ている issue
-
difficulty: easy
難易度 2/5 1〜3時間 初心者へのやさしさ 64/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
-
performance solver
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
ChefKissInc/Inferno#319 ·
-
llvm-tools
難易度 1/5 1時間未満 初心者へのやさしさ 72/100
llvm/llvm-project#235522 ·
メンテナーはふだん 1 日以内に返信