Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Nothing checks the message catalogs, or catches new hard-coded text

オープン
  • 何か問題がありますか？
#623 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
48/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
eslint, javascript, json, typescript
領域
internationalization, testing, tooling

調査の方向性

Start by reviewing the catalog setup and local ESLint plugin introduced in issue #620, then inspect src/messages/*.json, SHIPPED, and the pnpm test and lint configuration. Add fixture coverage for missing keys, ICU syntax, placeholders, unused keys, JSX text, and text bearing props; done means the listed lint, typecheck, knip, and test commands pass. This is step 0.4 of the owner's plan and depends on #620.

索引モデルが issue の本文から書いたものです。

説明

enhancement pipeline:proposed

Needs your OK: this adds checks on the translation catalogs and lint rules against hard-coded text. Nothing anyone sees changes. Swap pipeline:proposed for pipeline:ready to have it built.

What happens

Once text lives in src/messages/*.json (#620), nothing stops a translation from missing keys, breaking ICU syntax or dropping a {name}. Nothing stops new English being typed straight into a component either.

Fix, in outline

  • A catalog check that pnpm test runs (a unit test over src/messages/, so CI covers it with no workflow change). It checks that:
    • every catalog's completeness is known per namespace against en.json, and each language in SHIPPED is complete for its audience (participant: participant, email, common; organizer: organizer, auth, common; site: site, common);
    • every message compiles with icu-minify, which uses the same ICU parser as use-intl's full formatter;
    • placeholders and tags match the English source;
    • no key is unused.
  • Keys are literal, so the unused-key check can see them. Map enum values to keys through a typed table (const STATUS_KEY = { open: 'status.open', … } as const), never t(`status.${s}`).
  • Lint for hard-coded text:
    • react/jsx-no-literals with noStrings: true, ignoreProps: true for JSX text;
    • a small custom rule, in the local ESLint plugin from #620, that reports a string literal on text-bearing props: aria-label, aria-description, title, placeholder, alt and label.
    • Both are turned on per directory as each area moves to the catalog, starting with none.

Watch for

  • noAttributeStrings doesn't work here. It flags every className and href, and eslint-plugin-react 7.37.5 (what the lockfile resolves) has no per-attribute option.
  • Pin icu-minify as a devDependency at the exact version next-intl resolves, so the check runs the parser production runs.

Order

After #620, because the catalogs, SHIPPED and the local ESLint plugin come from it.

Done when

  • The check fails on a missing key, broken ICU, a dropped placeholder and an unused key (tests with fixture catalogs).
  • The lint rules fail on a fixture with JSX text and one with aria-label="…".
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test pass.

Planned with the owner in https://claude.ai/code/session_01EFKmj716ZY3b3SwR8TV8Y2 and checked against the code on main at 35288fa. The full plan is private to the owner's account: https://claude.ai/artifact/VgQH6U2s2EVx3LX991fJi8 (a Claude session on that account can open it with the Artifact tool's read action). This is step 0.4 there.

主要言語
TypeScript
スター
19
フォーク
4
平均マージ
19時間 34分
マージ済み PR（30日）
165

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

richshaw/OpenSignup のほかの issue

richshaw/OpenSignup の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。