The organizer's preview opens in a new tab with no way back to the signup
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 45/100
- issue の種類
- 機能追加
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- next.js, react, typescript
調査の方向性
Start with src/components/banner.tsx and src/app/s/[slug]/signup-view.tsx, then trace the Preview links in src/components/signup/SignupHeader.tsx and src/components/signup/HeaderParts.tsx. Review the listed unit and e2e tests, plus the help page text and screenshot mentioned in the issue. Done means the preview includes a working Back to editing link for every status, opens in the same tab, and the updated checks and listed project commands pass.
索引モデルが issue の本文から書いたものです。
説明
Needs your OK: this changes how Preview opens and adds a link back to the signup on the preview page. Swap pipeline:proposed for pipeline:ready to have it built.
What happens
- Preview opens a new tab. On a computer, the Preview link in
SignupHeader(src/components/signup/SignupHeader.tsx) hastarget="_blank". Onmaina phone has no Preview at all. #578 adds one to the phone's More actions sheet (PhonePreviewIteminsrc/components/signup/HeaderParts.tsx), also as a new tab, "as on a computer". - The preview page has no way out.
src/app/app/signups/[id]/preview/page.tsxsits outside the organizer layout. It has no header, no breadcrumb and no link back. It shows the Preview banner ("This is what people will see once you publish. No signups will be saved.") and the page, and nothing else. A draft can't be published from it. - The new tab has no history. The page itself offers no way back, so the organizer has to find the editor through the browser's tabs. On a phone that tab is easy to lose.
- Assistants link here too. The AI connector gives organizers
links.preview(previewPageUrlinsrc/lib/links.ts). They land on the same page, with no way into the editor.
To see it: create a signup with one slot. On a computer, choose Preview. A new tab opens on the preview, and nothing on it leads back to the signup or to Publish.
Fix, in outline
- Put "Back to editing" on the preview page. Add it as a link in the Preview banner, after the text. Point it at
/app/signups/[id]. That route sends the organizer to Build today, and will send a draft to #502's review page if that lands, so the link stays right.Banner(src/components/banner.tsx) takes only a title and a body. Give it an optional action slot. Don't draw a second banner.SignupView(src/app/s/[slug]/signup-view.tsx) draws the preview banner inpreviewmode. Only the preview page uses that mode, so the page can pass the link in.
- Open Preview in the same tab. Drop
target="_blank"from the computer's Preview link inSignupHeaderand fromPhonePreviewItem. The browser's Back then works as well. - Leave Publish where it is. Back to editing lands one tap from Publish and share: the header button on a computer, the bar at the bottom on a phone after #578.
Watch for
- Tests that pin the new tab.
tests/e2e/help/create-and-publish-a-signup.spec.tsopens Preview by waiting for a new page. #578'sMobileSignupHeader.test.tsxcheckstarget="_blank"and that the sheet closes "as Preview opens its tab". #578'sSignupHeader.test.tsxchecks the link too. - Help page.
create-and-publish-a-signupsays Preview "opens in a new tab". Update the text and any screenshot that shows the preview (help-pages skill). - Every status. The banner's text differs for draft, open, closed and archived (
previewCopyinSignupView). The link goes on all four. - The load-error card. When the signup can't load, the page shows
SignupLoadError, which already has "Back to dashboard". Leave it. - Telemetry.
signup.previewedis recorded when the page loads. Nothing about it changes. - CHANGELOG: add a line under Unreleased › Changed.
Choices this makes
- Same tab on a phone and a computer. Once the page has its own way back, a new tab only adds a tab to lose. The other option is the same tab on a phone only, keeping a computer's new tab for checking side by side.
- No Publish on the preview page. Publishing here would need #580's check and #574's share panel on this page too. Back to editing puts Publish one tap away. A Publish and share button in the banner for drafts could follow as its own issue.
- The words "Back to editing", with a left arrow, for every status. Participant pages say "Back to the signup", but here the organizer goes back to change it. For an open or closed signup it still leads to Build.
- In the banner, not a bar above it, so everything under the banner still looks exactly like the public page.
Order
After #578, because it adds the phone's Preview item and rewrites the computer's Preview link and the help text about it. Built first, this change would have to be redone on all three.
Done when
- On a computer and at 390px wide, Preview opens in the same tab, and the browser's Back returns to the signup.
- The preview page shows "Back to editing" in its banner for a draft, an open, a closed and an archived signup. It leads to
/app/signups/[id]. - The preview page opened on its own, as from an assistant's link, shows the same link.
- The tests that pinned the new tab check the same tab instead, and an e2e check follows Back to editing from the preview to the signup.
pnpm lint && pnpm typecheck && pnpm knip && pnpm testpass.
Found by the UX walkthrough (scenarios X1 and O1) on 2026-10-24, and checked against the code on main at 4ed27a9.
Generated by Claude Code
- 主要言語
- TypeScript
- スター
- 19
- フォーク
- 4
- 平均マージ
- 20時間 9分
- マージ済み PR(30日)
- 156
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
richshaw/OpenSignup のほかの issue
-
enhancement pipeline:proposed pipeline:ux
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
richshaw/OpenSignup#654 ·
メンテナーはふだん 1 日以内に返信
-
enhancement pipeline:proposed pipeline:ux
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
richshaw/OpenSignup#653 ·
メンテナーはふだん 1 日以内に返信
-
enhancement pipeline:proposed pipeline:ux
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
richshaw/OpenSignup#652 ·
メンテナーはふだん 1 日以内に返信
-
enhancement good first issue pipeline:ready
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
richshaw/OpenSignup#645 ·
メンテナーはふだん 1 日以内に返信
-
bug good first issue pipeline:ready pipeline:ux
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
richshaw/OpenSignup#644 ·
メンテナーはふだん 1 日以内に返信
richshaw/OpenSignup の issue をすべて見る
似ている issue
-
a10y a10y-audit ai-driven-qa claude
難易度 2/5 1〜3時間 初心者へのやさしさ 86/100
linagora/twake-directory-manager#219 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 1 日以内に返信
-
type: bug
難易度 2/5 1〜3時間 初心者へのやさしさ 79/100
メンテナーはふだん 1 日以内に返信
-
0️⃣ phase/new
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
-
Pulse v7: buildPreferencesFromTelos() bypasses telosSectionOrFile(), renders empty on unified-TELOS installs対応中かも @zephyr91 が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
danielmiessler/LifeOS#2393 ·
メンテナーはふだん 4 日以内に返信